[NTP Snippets] More reliable service initialization

[NTP Snippets] More reliable service initialization

The service was trying to guess if it should be enabled or not
during its initialization if the sync state was not available.
We now wait until the sync service is up to change states.

BUG=618361, 618280
Committed: https://crrev.com/df9b2e3b028162b21b4b4a2ce6344bf0c873b9b9
Cr-Commit-Position: refs/heads/master@{#398914}

[dgn, 2016-06-09 15:12:14]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org, treib@chromium.org

[dgn, 2016-06-09 15:12:15]

PTAL

https://codereview.chromium.org/2051823003/diff/20001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_service.h (left):

https://codereview.chromium.org/2051823003/diff/20001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_service.h:180: // - READY: noop
removed since now same-state transitions are generally noops

[Bernhard Bauer, 2016-06-09 15:21:34]

https://codereview.chromium.org/2051823003/diff/60001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_service.cc (right):

https://codereview.chromium.org/2051823003/diff/60001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_service.cc:581: void
NTPSnippetsService::LoadingSnippetsFinished() {
This is now more FetchingSnippetsFinished(). You could also inline it into
OnFetchFinished(), as that's the only call site.

https://codereview.chromium.org/2051823003/diff/60001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_service.cc:660: // service. Whether we had
snippets in the last season is used to guess if
"last session" :)

[Marc Treib, 2016-06-09 15:52:44]

LGTM, thanks! (with Bernhard's comments)

https://codereview.chromium.org/2051823003/diff/60001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_service.cc (right):

https://codereview.chromium.org/2051823003/diff/60001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_service.cc:587: // over into |to_delete| as
well.
nit: remove "as well"

[dgn, 2016-06-09 16:03:38]

https://codereview.chromium.org/2051823003/diff/60001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_service.cc (right):

https://codereview.chromium.org/2051823003/diff/60001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_service.cc:581: void
NTPSnippetsService::LoadingSnippetsFinished() {
On 2016/06/09 15:21:33, Bernhard Bauer wrote:
> This is now more FetchingSnippetsFinished(). You could also inline it into
> OnFetchFinished(), as that's the only call site.

Done.

https://codereview.chromium.org/2051823003/diff/60001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_service.cc:587: // over into |to_delete| as
well.
On 2016/06/09 15:52:44, Marc Treib wrote:
> nit: remove "as well"

Done.

https://codereview.chromium.org/2051823003/diff/60001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_service.cc:660: // service. Whether we had
snippets in the last season is used to guess if
On 2016/06/09 15:21:33, Bernhard Bauer wrote:
> "last session" :)

Thanks. The comment was outdated also u_u

[dgn, 2016-06-09 16:03:43]

The CQ bit was checked by dgn@chromium.org

[dgn, 2016-06-09 16:03:44]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2051823003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-06-09 16:04:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051823003/100001

[commit-bot: I haz the power, 2016-06-09 16:41:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-09 16:41:47]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 16:47:25]

Description was changed from

==========
[NTP Snippets] More reliable service initialization

The service was trying to guess if it should be enabled or not
during its initialization if the sync state was not available.
We now wait until the sync service is up to change states.

BUG=618361,618280
==========

to

==========
[NTP Snippets] More reliable service initialization

The service was trying to guess if it should be enabled or not
during its initialization if the sync state was not available.
We now wait until the sync service is up to change states.

BUG=618361,618280

Committed: https://crrev.com/df9b2e3b028162b21b4b4a2ce6344bf0c873b9b9
Cr-Commit-Position: refs/heads/master@{#398914}
==========

[commit-bot: I haz the power, 2016-06-09 16:47:26]

Patchset 6 (id:??) landed as
https://crrev.com/df9b2e3b028162b21b4b4a2ce6344bf0c873b9b9
Cr-Commit-Position: refs/heads/master@{#398914}