Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2051823002: Reland of [ic] Don't pollute per-map code cache with CompareIC stubs. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [ic] Don't pollute per-map code cache with CompareIC stubs. (patchset #1 id:1 of https://codereview.chromium.org/2055793002/ ) Reason for revert: Not the cause... Original issue's description: > Revert of [ic] Don't pollute per-map code cache with CompareIC stubs. (patchset #1 id:20001 of https://codereview.chromium.org/2053583002/ ) > > Reason for revert: > [Sheriff] Speculative revert. Tail call test timing out: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10014 > > Original issue's description: > > [ic] Don't pollute per-map code cache with CompareIC stubs. > > > > Given that > > 1) because of code flags mismatch we are not able to fetch any CompareIC stub that was put into the cache (we put MONOMORPHIC stubs but query only UNINITIALIZED ones), > > 2) it was already broken for a couple of years, > > 3) we will not need to cache any stub once CompareIC becomes vector-based. > > > > Committed: https://crrev.com/172ddf4250e5c4b7510ce352631fb9f8eb291940 > > Cr-Commit-Position: refs/heads/master@{#36854} > > TBR=verwaest@chromium.org,jkummerow@chromium.org,ishell@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/1d2ee8fd10adbfa5d213462c46181fa1ca899a61 > Cr-Commit-Position: refs/heads/master@{#36856} TBR=verwaest@chromium.org,jkummerow@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8898fef850f431c86bdf22f431ef915937779c65 Cr-Commit-Position: refs/heads/master@{#36857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -36 lines) Patch
M src/code-stubs.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Reland of [ic] Don't pollute per-map code cache with CompareIC stubs.
4 years, 6 months ago (2016-06-09 12:30:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051823002/1
4 years, 6 months ago (2016-06-09 12:30:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 12:30:25 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 12:34:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8898fef850f431c86bdf22f431ef915937779c65
Cr-Commit-Position: refs/heads/master@{#36857}

Powered by Google App Engine
This is Rietveld 408576698