Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: reviewbot/handlers/policy_checklist/modification_comment.txt

Issue 20518002: Implement mail dispatcher app. (Closed) Base URL: https://src.chromium.org/chrome/trunk/tools/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « reviewbot/handlers/policy_checklist/handler.py ('k') | reviewbot/handlers/policy_checklist/parser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: reviewbot/handlers/policy_checklist/modification_comment.txt
===================================================================
--- reviewbot/handlers/policy_checklist/modification_comment.txt (revision 0)
+++ reviewbot/handlers/policy_checklist/modification_comment.txt (revision 0)
@@ -0,0 +1,17 @@
+When modifying an existing policy setting, please consider the following:
+
+- Make sure the policy meta data is up-to-date, in particular
+ supported_on, and the feature flags.
+- In general, don't change policy semantics in a way that is
+ incompatible (as determined by user/admin-visible behavior) with
+ previous semantics. In particular, consider that existing policy
+ deployments may affect both old and new browser versions, and both
+ should behave according to the admin's intentions.
+- It is OK to expand semantics of policy values as long as the previous
+ policy description is compatible with the new behavior.
+- It is OK to update feature implementations and the policy description
+ when Chrome changes as long as the intended effect of the policy
+ remains intact.
+- The process for removing policies is to deprecate them first, wait a
+ few releases (if possible) and then remove them. Make sure you put the
+ deprecated flag if you deprecate a policy.
Property changes on: reviewbot/handlers/policy_checklist/modification_comment.txt
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « reviewbot/handlers/policy_checklist/handler.py ('k') | reviewbot/handlers/policy_checklist/parser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698