Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2051783002: [interpreter] Fix debug stepping for generators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/parsing/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index 044cf16f664946c1d525787522ce65372e530ff6..018640d806ffdbdaa9d0a0340f91f0b6cf18c738 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -214,7 +214,6 @@ class BytecodeGenerator::ControlScopeForTopLevel final
case CMD_CONTINUE:
UNREACHABLE();
case CMD_RETURN:
- generator()->builder()->SetReturnPosition();
generator()->builder()->Return();
return true;
case CMD_RETHROW:
@@ -2289,6 +2288,7 @@ void BytecodeGenerator::VisitYield(Yield* expr) {
}
builder()->Bind(&resume_with_throw);
+ builder()->SetExpressionPosition(expr);
builder()->LoadAccumulatorWithRegister(input).Throw();
builder()->Bind(&resume_with_next);
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/parsing/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698