Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: tools/perf/benchmarks/memory_infra.py

Issue 2051773002: [DoNotSubmit] Added peak_size to v8/malloc and test benchmark. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/v8_isolate_memory_dump_provider.cc ('k') | tools/perf/page_sets/test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/memory_infra.py
diff --git a/tools/perf/benchmarks/memory_infra.py b/tools/perf/benchmarks/memory_infra.py
index 1ac4e7d78ce1b4f26b7ff309bfa4fc5158a2179c..be967921132edc09eb285ada0425713d2eabb829 100644
--- a/tools/perf/benchmarks/memory_infra.py
+++ b/tools/perf/benchmarks/memory_infra.py
@@ -33,7 +33,7 @@ class _MemoryInfra(perf_benchmark.PerfBenchmark):
options.AppendExtraBrowserArgs([
# TODO(perezju): Temporary workaround to disable periodic memory dumps.
# See: http://crbug.com/513692
- '--enable-memory-benchmarking',
+ '--no-sandbox',
])
def CreateTimelineBasedMeasurementOptions(self):
@@ -207,3 +207,30 @@ class MemoryLongRunningIdleGmailBackground(_MemoryV8Benchmark):
@classmethod
def ShouldDisable(cls, possible_browser): # http://crbug.com/616530
return cls.IsSvelte(possible_browser)
+
+
+@benchmark.Enabled('android')
+class RendererMemoryTest(_MemoryInfra):
+ """Timeline based benchmark for measuring memory consumption on mobile
+ sites on which blink's memory consumption is relatively high."""
+
+ _RE_RENDERER_VALUES = re.compile('memory_.+_renderer')
+
+ page_set = page_sets.TestPageSet
+
+ def SetExtraBrowserOptions(self, options):
+ super(RendererMemoryTest, self).SetExtraBrowserOptions(
+ options)
+ options.AppendExtraBrowserArgs([
+ # Ignore certs errors because record_wpr cannot handle certs correctly
+ # in some cases (e.g. WordPress).
+ '--ignore-certificate-errors',
+ ])
+
+ @classmethod
+ def Name(cls):
+ return 'memory.test'
+
+ @classmethod
+ def ValueCanBeAddedPredicate(cls, value, is_first_result):
+ return bool(cls._RE_RENDERER_VALUES.match(value.name))
« no previous file with comments | « gin/v8_isolate_memory_dump_provider.cc ('k') | tools/perf/page_sets/test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698