Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: Source/modules/webaudio/PeriodicWave.h

Issue 205173002: Move webaudio to oilpan (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: WIP Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/PeriodicWave.h
diff --git a/Source/modules/webaudio/PeriodicWave.h b/Source/modules/webaudio/PeriodicWave.h
index bcb5776cf75574058b7040b587d44cc059980eb9..f255ca0437567f9acfe0d69b3bdbdf7f89338a56 100644
--- a/Source/modules/webaudio/PeriodicWave.h
+++ b/Source/modules/webaudio/PeriodicWave.h
@@ -40,15 +40,15 @@
namespace WebCore {
-class PeriodicWave : public ScriptWrappable, public RefCounted<PeriodicWave> {
+class PeriodicWave : public ScriptWrappable, public RefCountedWillBeGarbageCollectedFinalized<PeriodicWave> {
haraken 2014/03/27 11:44:05 You need to put RefCountedWillBeGarbageCollected i
keishi 2014/04/03 06:53:19 Done.
public:
- static PassRefPtr<PeriodicWave> createSine(float sampleRate);
- static PassRefPtr<PeriodicWave> createSquare(float sampleRate);
- static PassRefPtr<PeriodicWave> createSawtooth(float sampleRate);
- static PassRefPtr<PeriodicWave> createTriangle(float sampleRate);
+ static PassRefPtrWillBeRawPtr<PeriodicWave> createSine(float sampleRate);
+ static PassRefPtrWillBeRawPtr<PeriodicWave> createSquare(float sampleRate);
+ static PassRefPtrWillBeRawPtr<PeriodicWave> createSawtooth(float sampleRate);
+ static PassRefPtrWillBeRawPtr<PeriodicWave> createTriangle(float sampleRate);
// Creates an arbitrary periodic wave given the frequency components (Fourier coefficients).
- static PassRefPtr<PeriodicWave> create(float sampleRate, Float32Array* real, Float32Array* imag);
+ static PassRefPtrWillBeRawPtr<PeriodicWave> create(float sampleRate, Float32Array* real, Float32Array* imag);
// Returns pointers to the lower and higher wave data for the pitch range containing
// the given fundamental frequency. These two tables are in adjacent "pitch" ranges
@@ -63,6 +63,8 @@ public:
unsigned periodicWaveSize() const { return m_periodicWaveSize; }
+ void trace(Visitor*) { }
+
private:
explicit PeriodicWave(float sampleRate);

Powered by Google App Engine
This is Rietveld 408576698