Move webaudio to oilpan

Source/modules/webaudio/OscillatorNode.cpp

 /*
  * Copyright (C) 2012, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 25 matching lines @@
 #include "wtf/MathExtras.h"
 #include "wtf/StdLibExtras.h"
 #include <algorithm>
 
 using namespace std;
 
 namespace WebCore {
 
 using namespace VectorMath;
 
-PassRefPtr<OscillatorNode> OscillatorNode::create(AudioContext* context, float sampleRate)
+PassRefPtrWillBeRawPtr<OscillatorNode> OscillatorNode::create(AudioContext* context, float sampleRate)
 {
-    return adoptRef(new OscillatorNode(context, sampleRate));
+    return adoptRefWillBeNoop(new OscillatorNode(context, sampleRate));
 }
 
 OscillatorNode::OscillatorNode(AudioContext* context, float sampleRate)
     : AudioScheduledSourceNode(context, sampleRate)
     , m_type(SINE)
     , m_firstRender(true)
     , m_virtualReadIndex(0)
     , m_phaseIncrements(AudioNode::ProcessingSizeInFrames)
     , m_detuneValues(AudioNode::ProcessingSizeInFrames)
 {
@@ skipping 52 matching lines @@
         ASSERT_NOT_REACHED();
 }
 
 bool OscillatorNode::setType(unsigned type)
 {
     PeriodicWave* periodicWave = 0;
     float sampleRate = this->sampleRate();
 
     switch (type) {
     case SINE: {
+#if !ENABLE(OILPAN)
         DEFINE_STATIC_REF(PeriodicWave, periodicWaveSine, (PeriodicWave::createSine(sampleRate)));
         periodicWave = periodicWaveSine;
+#else
+        periodicWave = PeriodicWave::createSine(sampleRate);

[haraken, 2014/03/27 11:44:05]

You need to store the created pointer into a static persistent handle.
Otherwise, it will leak.

[keishi, 2014/04/03 06:53:19]

Done. Created DEFINE_STATIC_REF_WILL_BE_PERSISTENT

+#endif
         break;
     }
     case SQUARE: {
+#if !ENABLE(OILPAN)
         DEFINE_STATIC_REF(PeriodicWave, periodicWaveSquare, (PeriodicWave::createSquare(sampleRate)));
         periodicWave = periodicWaveSquare;
+#else
+        Persistent<PeriodicWave> periodicWaveSquare = PeriodicWave::createSquare(sampleRate);

[haraken, 2014/03/27 11:44:05]

Use DEFINE_STATIC_LOCAL.

[keishi, 2014/04/03 06:53:19]

Done.

+        periodicWave = periodicWaveSquare;
+#endif
         break;
     }
     case SAWTOOTH: {
+#if !ENABLE(OILPAN)
         DEFINE_STATIC_REF(PeriodicWave, periodicWaveSawtooth, (PeriodicWave::createSawtooth(sampleRate)));
         periodicWave = periodicWaveSawtooth;
+#else
+        Persistent<PeriodicWave> periodicWaveSawtooth = PeriodicWave::createSawtooth(sampleRate);

[haraken, 2014/03/27 11:44:05]

Ditto.

[keishi, 2014/04/03 06:53:19]

Done.

+        periodicWave = periodicWaveSawtooth;
+#endif
         break;
     }
     case TRIANGLE: {
+#if !ENABLE(OILPAN)
         DEFINE_STATIC_REF(PeriodicWave, periodicWaveTriangle, (PeriodicWave::createTriangle(sampleRate)));
         periodicWave = periodicWaveTriangle;
+#else
+        Persistent<PeriodicWave> periodicWaveTriangle = PeriodicWave::createTriangle(sampleRate);

[haraken, 2014/03/27 11:44:05]

Ditto.

Probably it might be worth introducing DEFINE_STATIC_REF_WILL_BE_PERSISTENT.
It's better to use #if ENABLE_OILPAN flag. We have this patter in several places
in the code base.

[keishi, 2014/04/03 06:53:19]

Done.

+        periodicWave = periodicWaveTriangle;
+#endif
         break;
     }
     case CUSTOM:
     default:
         // Return error for invalid types, including CUSTOM since setPeriodicWave() method must be
         // called explicitly.
         return false;
     }
 
     setPeriodicWave(periodicWave);
@@ skipping 188 matching lines @@
     MutexLocker processLocker(m_processLock);
     m_periodicWave = periodicWave;
     m_type = CUSTOM;
 }
 
 bool OscillatorNode::propagatesSilence() const
 {
     return !isPlayingOrScheduled() || hasFinished() || !m_periodicWave.get();
 }
 
+void OscillatorNode::trace(Visitor* visitor)
+{
+    visitor->trace(m_frequency);
+    visitor->trace(m_detune);
+    visitor->trace(m_periodicWave);
+    AudioNode::trace(visitor);

[Mads Ager (chromium), 2014/03/27 11:06:49]

We should call the immediate super class trace here:
AudioScheduledSourceNode::trace(visitor)

[keishi, 2014/04/03 06:53:19]

Done.

+}
+
 } // namespace WebCore
 
 #endif // ENABLE(WEB_AUDIO)