Move webaudio to oilpan

Source/modules/webaudio/AudioNode.h

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 32 matching lines @@
 class AudioNodeOutput;
 class AudioParam;
 class ExceptionState;
 
 // An AudioNode is the basic building block for handling audio within an AudioContext.
 // It may be an audio source, an intermediate processing module, or an audio destination.
 // Each AudioNode can have inputs and/or outputs. An AudioSourceNode has no inputs and a single output.
 // An AudioDestinationNode has one input and no outputs and represents the final destination to the audio hardware.
 // Most processing nodes such as filters will have one input and one output, although multiple inputs and outputs are possible.
 
-class AudioNode : public ScriptWrappable, public EventTargetWithInlineData {
+class AudioNode : public NoBaseWillBeGarbageCollectedFinalized<AudioNode>, public ScriptWrappable, public EventTargetWithInlineData {

[haraken, 2014/03/27 11:44:05]

Shouldn't this be NoBaseWillBeRefCountedGarbageCollected because AudioNode
inherits EventTarget? Actually I don't understand why this CL compiles with the
AudioNode being NoBaseWillBeGarbageCollectedFinalized.

[keishi, 2014/04/03 06:53:19]

Done.

 public:
     enum { ProcessingSizeInFrames = 128 };
 
     AudioNode(AudioContext*, float sampleRate);
     virtual ~AudioNode();
 
     AudioContext* context() { return m_context.get(); }
     const AudioContext* context() const { return m_context.get(); }
 
     enum NodeType {
@@ skipping 108 matching lines @@
     String channelInterpretation();
     void setChannelInterpretation(const String&, ExceptionState&);
 
     ChannelCountMode internalChannelCountMode() const { return m_channelCountMode; }
     AudioBus::ChannelInterpretation internalChannelInterpretation() const { return m_channelInterpretation; }
 
     // EventTarget
     virtual const AtomicString& interfaceName() const OVERRIDE FINAL;
     virtual ExecutionContext* executionContext() const OVERRIDE FINAL;
 
+    virtual void trace(Visitor*);
+
+#if ENABLE(OILPAN)
+    void clearKeepAlive();
+#endif
+
 protected:
     // Inputs and outputs must be created before the AudioNode is initialized.
     void addInput(PassOwnPtr<AudioNodeInput>);
     void addOutput(PassOwnPtr<AudioNodeOutput>);
 
     // Called by processIfNecessary() to cause all parts of the rendering graph connected to us to process.
     // Each rendering quantum, the audio data for each of the AudioNode's inputs will be available after this method is called.
     // Called from context's audio thread.
     virtual void pullInputs(size_t framesToProcess);
 
     // Force all inputs to take any channel interpretation changes into account.
     void updateChannelsForInputs();
 
 private:
     volatile bool m_isInitialized;
     NodeType m_nodeType;
-    RefPtr<AudioContext> m_context;
+    RefPtrWillBeMember<AudioContext> m_context;
     float m_sampleRate;
     Vector<OwnPtr<AudioNodeInput> > m_inputs;
     Vector<OwnPtr<AudioNodeOutput> > m_outputs;
 
+#if ENABLE(OILPAN)
+    // AudioNodes are still reference counted but they are in the
+    // oilpan heap because the ScriptProcessorNode is an EventTarget.
+    // This self-persistent keeps the object from being deleted
+    // until the reference count reaches zero.

[haraken, 2014/03/27 11:44:05]

If this statement is true, shouldn't we add an OwnPtr<Persistent<AudioNode>> to
ScriptProcessorNode instead of adding a keep alive handle to AudioNode?

[keishi, 2014/04/03 06:53:19]

Done.

+    //
+    // It is safe to drop the self-persistent when the ref count
+    // of a ScriptProcessorNode reaches zero. At that point, the
+    // ScriptProcessor node is removed from the AudioContext and
+    // it cannot be reattached. Therefore, the reference count
+    // will not go above zero again.

[haraken, 2014/03/27 11:44:05]

Can we add an ASSERT about the fact?

[keishi, 2014/04/08 02:33:40]

Done. Added an ASSERT to AudioNode::ref

+    OwnPtr<Persistent<AudioNode> > m_keepAlive;
+#endif
+
     double m_lastProcessingTime;
     double m_lastNonSilentTime;
 
     // Ref-counting
     volatile int m_normalRefCount;
     volatile int m_connectionRefCount;
 
     bool m_isMarkedForDeletion;
     bool m_isDisabled;
 
 #if DEBUG_AUDIONODE_REFERENCES
     static bool s_isNodeCountInitialized;
     static int s_nodeCount[NodeTypeEnd];
 #endif
 
     virtual void refEventTarget() OVERRIDE FINAL { ref(); }
     virtual void derefEventTarget() OVERRIDE FINAL { deref(); }
 
 protected:
     unsigned m_channelCount;
     ChannelCountMode m_channelCountMode;
     AudioBus::ChannelInterpretation m_channelInterpretation;
 };
 
 } // namespace WebCore
 
 #endif // AudioNode_h