third_party/WebKit/Source/core/layout/LayoutBox.h - Issue 2051703002: Implement closed shadow adjustment for Element.offsetParent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2051703002: Implement closed shadow adjustment for Element.offsetParent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add one more test case. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h

index 8e66825b56dafd2d2d11db87f1044c8c58b7f684..ca52d258eeabb66f7353e856939b932881e1c417 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h

@@ -425,8 +425,8 @@ public:

LayoutUnit offsetWidth() const override { return m_frameRect.width(); }

LayoutUnit offsetHeight() const override { return m_frameRect.height(); }

- int pixelSnappedOffsetWidth() const final;

- int pixelSnappedOffsetHeight() const final;

+ int pixelSnappedOffsetWidth(const Element*) const final;

+ int pixelSnappedOffsetHeight(const Element*) const final;

// More IE extensions. clientWidth and clientHeight represent the interior of an object

// excluding border and scrollbar. clientLeft/Top are just the borderLeftWidth and borderTopWidth.

@@ -836,8 +836,8 @@ public:

LayoutUnit lineHeight(bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const override;

int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const override;

- LayoutUnit offsetLeft() const override;

- LayoutUnit offsetTop() const override;

+ LayoutUnit offsetLeft(const Element*) const override;

+ LayoutUnit offsetTop(const Element*) const override;

LayoutPoint flipForWritingModeForChild(const LayoutBox* child, const LayoutPoint&) const;

LayoutUnit flipForWritingMode(LayoutUnit position) const WARN_UNUSED_RETURN {