third_party/WebKit/Source/core/page/PrintContext.cpp - Issue 2051703002: Implement closed shadow adjustment for Element.offsetParent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/PrintContext.cpp

Issue 2051703002: Implement closed shadow adjustment for Element.offsetParent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re-revert the previous and check position:fixed in layout code. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutObject.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutVideo.cpp ('k') | third_party/WebKit/Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/PrintContext.cpp

diff --git a/third_party/WebKit/Source/core/page/PrintContext.cpp b/third_party/WebKit/Source/core/page/PrintContext.cpp

index ccddc2e8c7c8162c884d2c7664d02d29841fab11..d86243482f4168c79b2683b6af7c6276596c52d0 100644

--- a/third_party/WebKit/Source/core/page/PrintContext.cpp

+++ b/third_party/WebKit/Source/core/page/PrintContext.cpp

@@ -203,8 +203,8 @@ int PrintContext::pageNumberForElement(Element* element, const FloatSize& pageSi

scaledPageSize.scale(frame->view()->contentsSize().width() / pageRect.width());

printContext.computePageRectsWithPageSize(scaledPageSize);

- int top = box->pixelSnappedOffsetTop();

- int left = box->pixelSnappedOffsetLeft();

+ int top = box->pixelSnappedOffsetTop(box->offsetParent());

+ int left = box->pixelSnappedOffsetLeft(box->offsetParent());

size_t pageNumber = 0;

for (; pageNumber < printContext.pageCount(); pageNumber++) {

const IntRect& page = printContext.pageRect(pageNumber);