Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html

Issue 2051703002: Implement closed shadow adjustment for Element.offsetParent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: *ForBinding Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html b/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
index 9127ebfea6f8bb18f5a21d1762723df9218a6ffc..2e93b10a12f3a81ae5f3e83baed417ed6faaa44a 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
@@ -31,14 +31,15 @@ shadow.positionedElement.removeAttribute('style');
shouldBe('child.offsetParent', 'container');
// Test that when the offsetParent is in user agent Shadow DOM, it is
-// not exposed to script
+// not exposed to script, but its shadow host or the host's ancestor
+// which is appropriate as an offsetParent is returned.
host = document.createElement('details');
container.appendChild(host);
host.setAttribute('open', 'open');
host.appendChild(child);
var shadow = window.internals.youngestShadowRoot(host); // this is a UA shadow root
configureShadowRoot(shadow);
-shouldBe('child.offsetParent', 'null');
+shouldBe('child.offsetParent', 'container');
// Test that offsetParent works 'through' user agent Shadow DOM when there is no
// positioned ancestor in user agent Shadow DOM

Powered by Google App Engine
This is Rietveld 408576698