third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2051703002: Implement closed shadow adjustment for Element.offsetParent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2051703002: Implement closed shadow adjustment for Element.offsetParent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Element.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutObject.h ('k') | third_party/WebKit/Source/core/layout/LayoutVideo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index 7b7996ca542c27b32613429569ccd690bd5d2d9f..a3338a4cedc35febe6238e96a23f4964e0f4fc9e 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -3279,6 +3279,16 @@ Element* LayoutObject::offsetParent() const

return node && node->isElementNode() ? toElement(node) : nullptr;

}

+Element* LayoutObject::unclosedOffsetParent() const

+ Element* element = offsetParent();

+ while (element && (!element->isUnclosedNodeOf(*node()) || (element->isInShadowTree() && element->containingShadowRoot()->type() == ShadowRootType::UserAgent)))

+ element = element->layoutObject()->offsetParent();

+ return element;

PositionWithAffinity LayoutObject::createPositionWithAffinity(int offset, TextAffinity affinity)

{

// If this is a non-anonymous layoutObject in an editable area, then it's simple.