third_party/WebKit/Source/core/layout/LayoutInline.cpp - Issue 2051703002: Implement closed shadow adjustment for Element.offsetParent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 2051703002: Implement closed shadow adjustment for Element.offsetParent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rename functions, update comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutInline.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.cpp b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

index ebec54584303173c6badac797b30233b7cdf8fbe..6f8e73f4000ee7b313cfcdc3b64509c566b563f6 100644

--- a/third_party/WebKit/Source/core/layout/LayoutInline.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

@@ -692,7 +692,7 @@ LayoutUnit LayoutInline::offsetLeft() const

if (InlineBox* firstBox = firstLineBoxIncludingCulling()) {

topLeft = firstBox->topLeft();

}

- return adjustedPositionRelativeToOffsetParent(topLeft).x();

+ return adjustedPositionRelativeToUnclosedOffsetParent(topLeft).x();

}

LayoutUnit LayoutInline::offsetTop() const

@@ -701,7 +701,7 @@ LayoutUnit LayoutInline::offsetTop() const

if (InlineBox* firstBox = firstLineBoxIncludingCulling()) {

topLeft = firstBox->topLeft();

}

- return adjustedPositionRelativeToOffsetParent(topLeft).y();

+ return adjustedPositionRelativeToUnclosedOffsetParent(topLeft).y();

}

static LayoutUnit computeMargin(const LayoutInline* layoutObject, const Length& margin)