third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp - Issue 2051693002: yaho

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

Issue 2051693002: yaho Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequest.idl ('k') | third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

index 6b17dc3aef2ebcd285d0efc6323ec1b9901df998..6fd13e785d43ef25cb11bc2be0a1f35779ca284a 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

@@ -9,7 +9,7 @@

#include "core/dom/ExceptionCode.h"

#include "core/testing/DummyPageHolder.h"

#include "modules/payments/PaymentDetails.h"

-#include "modules/payments/PaymentDetailsTestHelper.h"

+#include "modules/payments/PaymentTestHelper.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "wtf/OwnPtr.h"

#include <ostream> // NOLINT

@@ -137,7 +137,7 @@ private:

TEST_P(PaymentRequestDetailsTest, ValidatesDetails)

{

- PaymentRequest::create(getScriptState(), Vector<String>(1, "foo"), GetParam().buildDetails(), getExceptionState());

+ PaymentRequest::create(getScriptState(), buildPaymentMethodDataForTest(), GetParam().buildDetails(), getExceptionState());

EXPECT_EQ(GetParam().expectException(), getExceptionState().hadException());

if (GetParam().expectException())