Vectorize the remaining material design shelf icons

ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h"
 
+#include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/shelf/shelf_constants.h"
 #include "ash/common/shelf/wm_shelf_util.h"
 #include "ash/keyboard/keyboard_ui.h"
 #include "ash/shelf/shelf.h"
 #include "ash/shelf/shelf_util.h"
 #include "ash/shell.h"
 #include "ash/system/status_area_widget.h"
 #include "ash/system/tray/system_tray_notifier.h"
 #include "ash/system/tray/tray_constants.h"
 #include "ash/system/tray/tray_utils.h"
 #include "grit/ash_resources.h"
 #include "grit/ash_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/events/event.h"
 #include "ui/gfx/image/image_skia.h"
+#include "ui/gfx/paint_vector_icon.h"
+#include "ui/gfx/vector_icons_public.h"
 #include "ui/views/controls/button/image_button.h"
 
 namespace ash {
 
 VirtualKeyboardTray::VirtualKeyboardTray(StatusAreaWidget* status_area_widget)
     : TrayBackgroundView(status_area_widget),
       button_(NULL) {
   button_ = new views::ImageButton(this);
-  button_->SetImage(views::CustomButton::STATE_NORMAL,
-                    ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
-                        IDR_AURA_UBER_TRAY_VIRTUAL_KEYBOARD));
+  if (MaterialDesignController::IsShelfMaterial()) {
+    gfx::ImageSkia image_md =
+        CreateVectorIcon(gfx::VectorIconId::SHELF_KEYBOARD, kShelfIconColor);
+    button_->SetImage(views::CustomButton::STATE_NORMAL, &image_md);

[James Cook, 2016/06/09 23:00:09]

see below

[tdanderson, 2016/06/09 23:51:41]

In this case I'm keeping it as-is since ImageButton only has a version of
SetImage() that accepts a const ImageSkia* parameter (calls to
ImageButton::SetImage() elsewhere in the codebase seem to follow the same
pattern).

If you'd like, in a follow up CL I could try introducing an overloaded version
of SetImage() to ImageButton, or I could make |image_md| into a member variable
of VirtualKeyboardTray. Just let me know if you think either of those would be
worthwhile.

[James Cook, 2016/06/10 00:14:40]

That's OK, it's fine as it is. There seems to be a lot of variation in the code
base between const ImageSkia* and const ImageSkia&, but that's an issue for
another day.

+  } else {
+    gfx::ImageSkia* image_non_md =
+        ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
+            IDR_AURA_UBER_TRAY_VIRTUAL_KEYBOARD);
+    button_->SetImage(views::CustomButton::STATE_NORMAL, image_non_md);
+  }
   button_->SetImageAlignment(views::ImageButton::ALIGN_CENTER,
                              views::ImageButton::ALIGN_MIDDLE);
 
   tray_container()->AddChildView(button_);
   SetContentsBackground();
   // The Shell may not exist in some unit tests.
   if (Shell::HasInstance())
     Shell::GetInstance()->keyboard_ui()->AddObserver(this);
 }
 
@@ skipping 52 matching lines @@
                                         const ui::Event& event) {
   DCHECK_EQ(button_, sender);
   PerformAction(event);
 }
 
 void VirtualKeyboardTray::OnKeyboardEnabledStateChanged(bool new_value) {
   SetVisible(Shell::GetInstance()->keyboard_ui()->IsEnabled());
 }
 
 }  // namespace ash