base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

extensions/browser/api/app_runtime/app_runtime_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/app_runtime/app_runtime_api.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 16 matching lines @@
 
 namespace app_runtime = api::app_runtime;
 
 namespace {
 
 void DispatchOnEmbedRequestedEventImpl(
     const std::string& extension_id,
     std::unique_ptr<base::DictionaryValue> app_embedding_request_data,
     content::BrowserContext* context) {
   std::unique_ptr<base::ListValue> args(new base::ListValue());
-  args->Append(app_embedding_request_data.release());
+  args->Append(std::move(app_embedding_request_data));
   std::unique_ptr<Event> event(
       new Event(events::APP_RUNTIME_ON_EMBED_REQUESTED,
                 app_runtime::OnEmbedRequested::kEventName, std::move(args)));
   event->restrict_to_browser_context = context;
   EventRouter::Get(context)
       ->DispatchEventWithLazyListener(extension_id, std::move(event));
 
   ExtensionPrefs::Get(context)
       ->SetLastLaunchTime(extension_id, base::Time::Now());
 }
 
 void DispatchOnLaunchedEventImpl(
     const std::string& extension_id,
     app_runtime::LaunchSource source,
     std::unique_ptr<base::DictionaryValue> launch_data,
     BrowserContext* context) {
   UMA_HISTOGRAM_ENUMERATION(
       "Extensions.AppLaunchSource", source, NUM_APP_LAUNCH_SOURCES);
 
   // "Forced app mode" is true for Chrome OS kiosk mode.
   launch_data->SetBoolean(
       "isKioskSession",
       ExtensionsBrowserClient::Get()->IsRunningInForcedAppMode());
 
   launch_data->SetBoolean(
       "isPublicSession",
       ExtensionsBrowserClient::Get()->IsLoggedInAsPublicAccount());
 
   std::unique_ptr<base::ListValue> args(new base::ListValue());
-  args->Append(launch_data.release());
+  args->Append(std::move(launch_data));
   std::unique_ptr<Event> event(new Event(events::APP_RUNTIME_ON_LAUNCHED,
                                          app_runtime::OnLaunched::kEventName,
                                          std::move(args)));
   event->restrict_to_browser_context = context;
   EventRouter::Get(context)
       ->DispatchEventWithLazyListener(extension_id, std::move(event));
   ExtensionPrefs::Get(context)
       ->SetLastLaunchTime(extension_id, base::Time::Now());
 }
 
@@ skipping 105 matching lines @@
   DCHECK(file_entries.size() == entries.size());
   for (size_t i = 0; i < file_entries.size(); ++i) {
     std::unique_ptr<base::DictionaryValue> launch_item(
         new base::DictionaryValue);
 
     launch_item->SetString("fileSystemId", file_entries[i].filesystem_id);
     launch_item->SetString("baseName", file_entries[i].registered_name);
     launch_item->SetString("mimeType", entries[i].mime_type);
     launch_item->SetString("entryId", file_entries[i].id);
     launch_item->SetBoolean("isDirectory", entries[i].is_directory);
-    items->Append(launch_item.release());
+    items->Append(std::move(launch_item));
   }
   launch_data->Set("items", items.release());
   DispatchOnLaunchedEventImpl(extension->id(), source_enum,
                               std::move(launch_data), context);
 }
 
 // static
 void AppRuntimeEventRouter::DispatchOnLaunchedEventWithUrl(
     BrowserContext* context,
     const Extension* extension,
     const std::string& handler_id,
     const GURL& url,
     const GURL& referrer_url) {
   app_runtime::LaunchData launch_data;
   app_runtime::LaunchSource source_enum =
       app_runtime::LAUNCH_SOURCE_URL_HANDLER;
   launch_data.id.reset(new std::string(handler_id));
   launch_data.url.reset(new std::string(url.spec()));
   launch_data.referrer_url.reset(new std::string(referrer_url.spec()));
   if (extensions::FeatureSwitch::trace_app_source()->IsEnabled()) {
     launch_data.source = source_enum;
   }
   DispatchOnLaunchedEventImpl(extension->id(), source_enum,
                               launch_data.ToValue(), context);
 }
 
 }  // namespace extensions