base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

chrome/browser/ui/tabs/pinned_tab_codec.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/tabs/pinned_tab_codec.h"
 
 #include <stddef.h>
 
+#include <utility>
+
 #include "base/values.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
 #include "chrome/common/pref_names.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_service.h"
@@ skipping 14 matching lines @@
     if (tab_model->IsTabPinned(i))
       return true;
   }
   return false;
 }
 
 // Adds a DictionaryValue to |values| representing |tab|.
 static void EncodeTab(const StartupTab& tab, base::ListValue* values) {
   std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue);
   value->SetString(kURL, tab.url.spec());
-  values->Append(value.release());
+  values->Append(std::move(value));
 }
 
 // Adds a base::DictionaryValue to |values| representing the pinned tab at the
 // specified index.
 static void EncodePinnedTab(TabStripModel* model,
                             int index,
                             base::ListValue* values) {
   std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue());
 
   content::WebContents* web_contents = model->GetWebContentsAt(index);
   NavigationEntry* entry = web_contents->GetController().GetActiveEntry();
   if (entry) {
     value->SetString(kURL, entry->GetURL().spec());
-    values->Append(value.release());
+    values->Append(std::move(value));
   }
 }
 
 // Invokes EncodePinnedTab for each pinned tab in browser.
 static void EncodePinnedTabs(Browser* browser, base::ListValue* values) {
   TabStripModel* tab_model = browser->tab_strip_model();
   for (int i = 0; i < tab_model->count() && tab_model->IsTabPinned(i); ++i)
     EncodePinnedTab(tab_model, i, values);
 }
 
@@ skipping 63 matching lines @@
   for (size_t i = 0, max = tabs_list->GetSize(); i < max; ++i) {
     const base::DictionaryValue* tab_values = NULL;
     if (tabs_list->GetDictionary(i, &tab_values)) {
       StartupTab tab;
       if (DecodeTab(*tab_values, &tab))
         results.push_back(tab);
     }
   }
   return results;
 }