Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2051653002: Add missing include (Closed)

Created:
4 years, 6 months ago by eostroukhov-old
Modified:
4 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing include This include is required for INT_MAX constant used in this file. Currently this compiles without this statement because the header gets pulled through WTF dependencies. BUG= Committed: https://crrev.com/b16647bc29dc3b90ccd83058bc7a0cc9c2b0a765 Cr-Commit-Position: refs/heads/master@{#398803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051653002/1
4 years, 6 months ago (2016-06-08 23:20:17 UTC) #2
eostroukhov-old
4 years, 6 months ago (2016-06-09 00:09:10 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/235900)
4 years, 6 months ago (2016-06-09 01:27:02 UTC) #6
pfeldman
lgtm
4 years, 6 months ago (2016-06-09 05:12:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051653002/1
4 years, 6 months ago (2016-06-09 05:13:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 07:20:56 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 07:23:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b16647bc29dc3b90ccd83058bc7a0cc9c2b0a765
Cr-Commit-Position: refs/heads/master@{#398803}

Powered by Google App Engine
This is Rietveld 408576698