Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: masters/master.chromium.lkgr/master_lkgr_cfg.py

Issue 2051583002: lkgr master: Port linux ubsan bots to recipes (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/config.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: masters/master.chromium.lkgr/master_lkgr_cfg.py
diff --git a/masters/master.chromium.lkgr/master_lkgr_cfg.py b/masters/master.chromium.lkgr/master_lkgr_cfg.py
index 3172bc432277d7d1a198a2b7a50e09f545cd2c45..95eec99dd75f9872fb33a94ff9cf6f50715780bc 100644
--- a/masters/master.chromium.lkgr/master_lkgr_cfg.py
+++ b/masters/master.chromium.lkgr/master_lkgr_cfg.py
@@ -377,41 +377,13 @@ B('Telemetry Harness Upload', 'telemetry_harness_upload', None, 'chromium_lkgr')
F('telemetry_harness_upload',
m_annotator.BaseFactory('perf/telemetry_harness_upload'))
-# The build process for UBSan vptr is described at
-# http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer
-ubsan_gyp = ('ubsan=1 ')
B('UBSan Release', 'linux_ubsan_rel', 'compile', 'chromium_lkgr')
-F('linux_ubsan_rel', linux().ChromiumFactory(
- clobber=True,
- compile_timeout=5400, # UBSan builds very slowly with edge level coverage
- target='Release',
- options=['--compiler=goma-clang', 'chromium_builder_asan'],
- factory_properties={
- 'cf_archive_build': ActiveMaster.is_production_host,
- 'cf_archive_name': 'ubsan',
- 'gs_bucket': 'gs://chromium-browser-ubsan',
- 'gs_acl': 'public-read',
- 'gclient_env': {'GYP_DEFINES': ubsan_gyp},
- 'use_mb': True,
- }))
-
-ubsan_vptr_gyp = ('ubsan_vptr=1 sanitizer_coverage=edge ')
+# UBSan builds very slowly with edge level coverage
+F('linux_ubsan_rel', m_annotator.BaseFactory(recipe='chromium', timeout=5400))
B('UBSan vptr Release', 'linux_ubsan_vptr_rel', 'compile', 'chromium_lkgr')
-F('linux_ubsan_vptr_rel', linux().ChromiumFactory(
- clobber=True,
- target='Release',
- options=['--compiler=goma-clang', 'chromium_builder_asan'],
- factory_properties={
- 'cf_archive_build': ActiveMaster.is_production_host,
- 'cf_archive_subdir_suffix': 'vptr',
- 'cf_archive_name': 'ubsan-vptr',
- 'gs_bucket': 'gs://chromium-browser-ubsan',
- 'gs_acl': 'public-read',
- 'gclient_env': {'GYP_DEFINES': ubsan_vptr_gyp},
- 'use_mb': True,
- }))
+F('linux_ubsan_vptr_rel', m_annotator.BaseFactory(recipe='chromium'))
def Update(_config, active_master, c):
lkgr_poller = gitiles_poller.GitilesPoller(
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698