Perform alarm's period limit check while reading alarm info from StateStore.

extensions/browser/api/alarms/alarms_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/alarms/alarms_api.h"
 
 #include <stddef.h>
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/time/clock.h"
 #include "base/time/default_clock.h"
 #include "base/values.h"
 #include "extensions/browser/api/alarms/alarm_manager.h"
+#include "extensions/browser/api/alarms/alarms_api_constants.h"
 #include "extensions/common/api/alarms.h"
 #include "extensions/common/error_utils.h"
 
 namespace extensions {
 
 namespace alarms = api::alarms;
 
 namespace {
 
 const char kDefaultAlarmName[] = "";
 const char kBothRelativeAndAbsoluteTime[] =
     "Cannot set both when and delayInMinutes.";
 const char kNoScheduledTime[] =
     "Must set at least one of when, delayInMinutes, or periodInMinutes.";
-const int kReleaseDelayMinimum = 1;
-const int kDevDelayMinimum = 0;
 
 bool ValidateAlarmCreateInfo(const std::string& alarm_name,
                              const alarms::AlarmCreateInfo& create_info,
                              const Extension* extension,
                              std::string* error,
                              std::vector<std::string>* warnings) {
   if (create_info.delay_in_minutes.get() && create_info.when.get()) {
     *error = kBothRelativeAndAbsoluteTime;
     return false;
   }
   if (create_info.delay_in_minutes == NULL && create_info.when == NULL &&
       create_info.period_in_minutes == NULL) {
     *error = kNoScheduledTime;
     return false;
   }
 
   // Users can always use an absolute timeout to request an arbitrarily-short or
   // negative delay.  We won't honor the short timeout, but we can't check it
   // and warn the user because it would introduce race conditions (say they
   // compute a long-enough timeout, but then the call into the alarms interface
   // gets delayed past the boundary).  However, it's still worth warning about
   // relative delays that are shorter than we'll honor.
   if (create_info.delay_in_minutes.get()) {
-    if (*create_info.delay_in_minutes < kReleaseDelayMinimum) {
-      static_assert(kReleaseDelayMinimum == 1,
-                    "warning message must be updated");

[asargent_no_longer_on_chrome, 2016/06/10 00:07:33]

optional: I see you moved these to a single assert in alarms_api_constants.cc.
It seems like that is slightly more likely to lead to someone blindly just
updating the value in the static_assert test without reading the error message
and realizing that it means the strings here need to be updated. My personal
preference would be to leave these as-is, but it isn't that big of a deal either
way. If you want to keep the change as you have it in the CL that's ok. 

[lazyboy, 2016/06/10 20:01:31]

I couldn't use static assert with variable declared/defined in
alarms_api_constants.h/cc
I've moved the warning messages too to alarms_api_constants.

+    if (*create_info.delay_in_minutes <
+        alarms_api_constants::kReleaseDelayMinimum) {
       if (Manifest::IsUnpackedLocation(extension->location()))
         warnings->push_back(ErrorUtils::FormatErrorMessage(
             "Alarm delay is less than minimum of 1 minutes."
             " In released .crx, alarm \"*\" will fire in approximately"
             " 1 minutes.",
             alarm_name));
       else
         warnings->push_back(ErrorUtils::FormatErrorMessage(
             "Alarm delay is less than minimum of 1 minutes."
             " Alarm \"*\" will fire in approximately 1 minutes.",
             alarm_name));
     }
   }
   if (create_info.period_in_minutes.get()) {
-    if (*create_info.period_in_minutes < kReleaseDelayMinimum) {
-      static_assert(kReleaseDelayMinimum == 1,
-                    "warning message must be updated");
+    if (*create_info.period_in_minutes <
+        alarms_api_constants::kReleaseDelayMinimum) {
       if (Manifest::IsUnpackedLocation(extension->location()))
         warnings->push_back(ErrorUtils::FormatErrorMessage(
             "Alarm period is less than minimum of 1 minutes."
             " In released .crx, alarm \"*\" will fire approximately"
             " every 1 minutes.",
             alarm_name));
       else
         warnings->push_back(ErrorUtils::FormatErrorMessage(
             "Alarm period is less than minimum of 1 minutes."
             " Alarm \"*\" will fire approximately every 1 minutes.",
@@ skipping 27 matching lines @@
       params->name.get() ? *params->name : kDefaultAlarmName;
   std::vector<std::string> warnings;
   if (!ValidateAlarmCreateInfo(alarm_name, params->alarm_info, extension(),
                                &error_, &warnings)) {
     return false;
   }
   for (std::vector<std::string>::const_iterator it = warnings.begin();
        it != warnings.end(); ++it)
     WriteToConsole(content::CONSOLE_MESSAGE_LEVEL_WARNING, *it);
 
-  Alarm alarm(alarm_name, params->alarm_info,
-              base::TimeDelta::FromMinutes(
-                  Manifest::IsUnpackedLocation(extension()->location())
-                      ? kDevDelayMinimum
-                      : kReleaseDelayMinimum),
-              clock_->Now());
+  const int kSecondsPerMinute = 60;
+  base::TimeDelta granularity =
+      base::TimeDelta::FromSecondsD(
+          (Manifest::IsUnpackedLocation(extension()->location())
+               ? alarms_api_constants::kDevDelayMinimum
+               : alarms_api_constants::kReleaseDelayMinimum)) *
+      kSecondsPerMinute;
+
+  Alarm alarm(alarm_name, params->alarm_info, granularity, clock_->Now());
   AlarmManager::Get(browser_context())
       ->AddAlarm(extension_id(), alarm,
                  base::Bind(&AlarmsCreateFunction::Callback, this));
 
   return true;
 }
 
 void AlarmsCreateFunction::Callback() {
   SendResponse(true);
 }
@@ skipping 60 matching lines @@
                         base::Bind(&AlarmsClearAllFunction::Callback, this));
   return true;
 }
 
 void AlarmsClearAllFunction::Callback() {
   SetResult(base::MakeUnique<base::FundamentalValue>(true));
   SendResponse(true);
 }
 
 }  // namespace extensions