Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2051563003: Move post-mortem constants from accessors table to constants table (Closed)

Created:
4 years, 6 months ago by julien.gilli
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move post-mortem constants from accessors table to constants table Some post-mortem metadata constants that are not offsets to objects' properties were incorrectly defined in the accessors table. This change fixes it by moving them from the accessors table to the constants table. More background is available at https://github.com/nodejs/post-mortem/issues/27. R=danno@chromium.org,bmeurer@chromium.org BUG= Committed: https://crrev.com/2619ccd1a0c29a558d08abfd1c25652567e19bcf Cr-Commit-Position: refs/heads/master@{#36878}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unintended change from previous patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M tools/gen-postmortem-metadata.py View 1 4 chunks +36 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
julien.gilli
https://codereview.chromium.org/2051563003/diff/1/tools/gen-postmortem-metadata.py File tools/gen-postmortem-metadata.py (right): https://codereview.chromium.org/2051563003/diff/1/tools/gen-postmortem-metadata.py#newcode160 tools/gen-postmortem-metadata.py:160: { 'name': 'off_fp_marker', This change was not supposed to ...
4 years, 6 months ago (2016-06-09 18:19:15 UTC) #1
julien.gilli
On 2016/06/09 18:19:15, julien.gilli wrote: > https://codereview.chromium.org/2051563003/diff/1/tools/gen-postmortem-metadata.py > File tools/gen-postmortem-metadata.py (right): > > https://codereview.chromium.org/2051563003/diff/1/tools/gen-postmortem-metadata.py#newcode160 > ...
4 years, 6 months ago (2016-06-09 23:22:24 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-10 03:44:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051563003/20001
4 years, 6 months ago (2016-06-10 03:44:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 04:06:25 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 04:09:15 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2619ccd1a0c29a558d08abfd1c25652567e19bcf
Cr-Commit-Position: refs/heads/master@{#36878}

Powered by Google App Engine
This is Rietveld 408576698