linux_aura: Don't inject black in WrenchMenu::GetForegroundColor().

linux_aura: Don't inject black in WrenchMenu::GetForegroundColor().

Through a chain of calls, WrenchMenu::RecentTabsMenuModelDelegate hard
coded the color black into menus, even when we were using light on dark
system themes. This was done to bold specific menu labels. Separate out
a specific bold disabled menu item color, thread this through the
NativeTheme interface and add an accessor on WrenchMenu to decide
whether to use it.

Adds TODOs in the MenuDelegate interface to remove the
Get{Foreground,Background}Color methods. These interfaces can't be used
safely on the desktop. They can't be removed yet, though, because of a
few remaining calls in ash/ that I don't understand.

BUG=351307
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258485

[sky, 2014-03-20 02:07:48]

https://codereview.chromium.org/205153003/diff/20001/ui/views/controls/menu/m...
File ui/views/controls/menu/menu_delegate.h (right):

https://codereview.chromium.org/205153003/diff/20001/ui/views/controls/menu/m...
ui/views/controls/menu/menu_delegate.h:70: virtual bool GetBoldedDisabled(int
command_id) const;
Bold implies a font. How about GetShouldUseDisabledEmphasizedForegroundColor.
And the constant to match, kColorId_DisabledEmphasizedMenuItemForegroundColor?

[Elliot Glaysher, 2014-03-20 19:52:25]

Done. PTAL.

[sky, 2014-03-20 21:06:46]

LGTM

[Elliot Glaysher, 2014-03-20 21:14:49]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2014-03-20 21:15:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/205153003/40001

[commit-bot: I haz the power, 2014-03-21 01:08:31]

Change committed as 258485