Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2051513002: Fix 2D canvas entiring invalid state when painted during hibernation (Closed)

Created:
4 years, 6 months ago by Justin Novosad
Modified:
4 years, 6 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 2D canvas entiring invalid state when painted during hibernation painting a canvas while the canvas is in a hibernation state was causing the canvas to allocate a non-accelerated surface backing, which would later cause GPU texture preparation to fail after exiting from hibernation. This fix prevents "Canvas2DLayerBridge::newImageSnapshot()" from triggering the creation of a surface whil the canvas is in a hibernating state. BUG=613513 Committed: https://crrev.com/6cfd221afcf593c701f2fce3ffbebdb4b2201968 Cr-Commit-Position: refs/heads/master@{#398681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 2 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Justin Novosad
PTAL
4 years, 6 months ago (2016-06-08 17:08:25 UTC) #2
Stephen White
LGTM Good find!
4 years, 6 months ago (2016-06-08 18:09:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051513002/1
4 years, 6 months ago (2016-06-08 18:33:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 21:26:52 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 21:28:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cfd221afcf593c701f2fce3ffbebdb4b2201968
Cr-Commit-Position: refs/heads/master@{#398681}

Powered by Google App Engine
This is Rietveld 408576698