Issue 20515: Fix plugin hang that Earth team found....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20515: Fix plugin hang that Earth team found.... (Closed)

Created:
11 years, 10 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix plugin hang that Earth team found. Normally an NPObjectProxy uses the modal dialog event to figure out when it needs to pump window messages in an invoke. However, an NPObjectProxy created by an NPObjectStub never got access to this event, which led to this hang. BUG=7793 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10145

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -20 lines)			Patch
M	chrome/plugin/npobject_proxy.cc	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
	chrome/plugin/npobject_stub.h	View	1 2	3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/plugin/npobject_stub.cc	View	1 2	6 chunks	+17 lines, -8 lines	0 comments	Download
M	chrome/plugin/npobject_util.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/plugin/npobject_util.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/plugin/webplugin_delegate_stub.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/plugin/webplugin_proxy.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/renderer/webplugin_delegate_proxy.cc	View		3 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages