Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2051433002: Add tests for resolving missing packages, relative and absolute URIs. (Closed)

Created:
4 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 6 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for resolving missing packages, relative and absolute URIs. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/419873dcd3774382318a3baa5a18bbc86f38b636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M tests/standalone/packages_file_test.dart View 12 chunks +27 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
4 years, 6 months ago (2016-06-08 11:08:49 UTC) #2
floitsch
LGTM.
4 years, 6 months ago (2016-06-08 11:19:54 UTC) #3
Lasse Reichstein Nielsen
4 years, 6 months ago (2016-06-09 09:36:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
419873dcd3774382318a3baa5a18bbc86f38b636 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698