Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2439)

Issue 2051423004: UMA cellular experiment by default (Closed)

Created:
4 years, 6 months ago by gayane -on leave until 09-2017
Modified:
4 years, 6 months ago
Reviewers:
nyquist
CC:
chromium-reviews, asvitkine+watch_chromium.org, gayane+watch_chromium.org, Alexei Svitkine (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable the behavior enforced by UMA cellular experiment as default behavior, with a functionality to disable it with variation params. UMA cellular experiment changes Chrome usage reporting settings from three-option model to just ON/OFF switch and enables cellular uploads if user gave consent. BUG=455847 Committed: https://crrev.com/1478c8ab9c929d3ae3ec7d5592e2fe39dcf2baa7 Cr-Commit-Position: refs/heads/master@{#399717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
gayane -on leave until 09-2017
Please have a look
4 years, 6 months ago (2016-06-10 20:24:34 UTC) #2
nyquist
the code lgtm, but can you please use the CL description to describe why and ...
4 years, 6 months ago (2016-06-13 20:23:04 UTC) #3
nyquist
the code lgtm, but can you please use the CL description to describe why and ...
4 years, 6 months ago (2016-06-13 20:23:04 UTC) #4
gayane -on leave until 09-2017
On 2016/06/13 20:23:04, nyquist wrote: > the code lgtm, but can you please use the ...
4 years, 6 months ago (2016-06-14 15:09:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051423004/1
4 years, 6 months ago (2016-06-14 15:10:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 15:55:29 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 15:55:40 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 15:59:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1478c8ab9c929d3ae3ec7d5592e2fe39dcf2baa7
Cr-Commit-Position: refs/heads/master@{#399717}

Powered by Google App Engine
This is Rietveld 408576698