Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2051413004: [arrays] Fix %GetArrayKeys for special element kinds (Closed)

Created:
4 years, 6 months ago by Camillo Bruni
Modified:
4 years, 6 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arrays] Fix %GetArrayKeys for special element kinds Array.prototype.sort would not work properly on sloppy arguments of size > 2. BUG=chromium:618613 Committed: https://crrev.com/8a88fc142f805dd0feba895ff692d5374ab224f2 Cr-Commit-Position: refs/heads/master@{#36920}

Patch Set 1 #

Patch Set 2 : fixed typed arrays are also packed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -9 lines) Patch
M src/runtime/runtime-array.cc View 1 2 chunks +7 lines, -9 lines 0 comments Download
M test/mjsunit/array-sort.js View 1 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
PTAL
4 years, 6 months ago (2016-06-10 12:50:34 UTC) #2
adamk
lgtm
4 years, 6 months ago (2016-06-10 12:55:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051413004/20001
4 years, 6 months ago (2016-06-13 09:36:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 10:06:31 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 10:07:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a88fc142f805dd0feba895ff692d5374ab224f2
Cr-Commit-Position: refs/heads/master@{#36920}

Powered by Google App Engine
This is Rietveld 408576698