Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 20514002: Simple interface for setting app config. (Closed)

Created:
7 years, 5 months ago by Mattias Nissler (ping if slow)
Modified:
7 years, 4 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews, cmp-cc_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/tools/
Visibility:
Public.

Description

Simple interface for setting app config. This adds a bare-bones HTML form for configuring the application config parameters, i.e. client ID, service account key, rietveld server URL and Rietveld nickname for the bot. R=iannucci@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216374

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
A reviewbot/app_config.py View 1 chunk +69 lines, -0 lines 2 comments Download
A reviewbot/third_party.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mattias Nissler (ping if slow)
Please review.
7 years, 4 months ago (2013-08-05 09:12:00 UTC) #1
Mattias Nissler (ping if slow)
cc agable
7 years, 4 months ago (2013-08-05 18:17:12 UTC) #2
Mattias Nissler (ping if slow)
Gentle ping - can one of you take a look?
7 years, 4 months ago (2013-08-08 10:14:42 UTC) #3
iannucci
lgtm https://codereview.chromium.org/20514002/diff/1/reviewbot/app_config.py File reviewbot/app_config.py (right): https://codereview.chromium.org/20514002/diff/1/reviewbot/app_config.py#newcode47 reviewbot/app_config.py:47: if e[1].status != 302: logging of some sort?
7 years, 4 months ago (2013-08-08 10:37:24 UTC) #4
Mattias Nissler (ping if slow)
https://codereview.chromium.org/20514002/diff/1/reviewbot/app_config.py File reviewbot/app_config.py (right): https://codereview.chromium.org/20514002/diff/1/reviewbot/app_config.py#newcode47 reviewbot/app_config.py:47: if e[1].status != 302: On 2013/08/08 10:37:25, iannucci wrote: ...
7 years, 4 months ago (2013-08-08 10:54:34 UTC) #5
Mattias Nissler (ping if slow)
7 years, 4 months ago (2013-08-08 10:54:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r216374 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698