cc/layers/picture_layer_impl_unittest.cc - Issue 2051343002: Make various gfx classes more amenable to use as compile-time constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 2051343002: Make various gfx classes more amenable to use as compile-time constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile and test fixes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/picture_layer_impl_unittest.cc

diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc

index fba2c6fe2c27a0af7e8960f5d3b476a137e488eb..7bd0d1597824844964cce8ad8b5bdb2dd08ad4c7 100644

--- a/cc/layers/picture_layer_impl_unittest.cc

+++ b/cc/layers/picture_layer_impl_unittest.cc

@@ -538,8 +538,6 @@ TEST_F(PictureLayerImplTest, ClonePartialInvalidation) {

EXPECT_GT(tilings->num_tilings(), 0u);

for (size_t i = 0; i < tilings->num_tilings(); ++i) {

const PictureLayerTiling* tiling = tilings->tiling_at(i);

- gfx::Rect content_invalidation =

- gfx::ScaleToEnclosingRect(layer_invalidation, tiling->contents_scale());

auto prioritized_tiles =

tiling->UpdateAndGetAllPrioritizedTilesForTesting();

for (PictureLayerTiling::CoverageIterator iter(

@@ -1640,7 +1638,6 @@ TEST_F(NoLowResPictureLayerImplTest,

ASSERT_EQ(1.f, pending_layer()->HighResTiling()->contents_scale());

// Set external viewport for tile priority.

- gfx::Rect viewport = gfx::Rect(layer_bounds);

gfx::Transform transform;

gfx::Transform transform_for_tile_priority;

host_impl()->SetExternalTilePriorityConstraints(

« no previous file with comments | « cc/layers/layer_unittest.cc ('k') | cc/layers/solid_color_layer_impl_unittest.cc » ('j') | cc/trees/occlusion_tracker_perftest.cc » ('J')