Make various gfx classes more amenable to use as compile-time constants.

cc/trees/occlusion_tracker_perftest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/occlusion_tracker.h"
 
 #include <stddef.h>
 
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/time/time.h"
@@ skipping 109 matching lines @@
         tracker.GetCurrentOcclusionForLayer(transform_to_target);
     for (int x = 0; x < viewport_rect.width(); x += 256) {
       for (int y = 0; y < viewport_rect.height(); y += 256) {
         gfx::Rect query_content_rect(x, y, 256, 256);
         gfx::Rect unoccluded =
             occlusion.GetUnoccludedContentRect(query_content_rect);
         // Sanity test that we're not hitting early outs.
         bool expect_empty =
             query_content_rect.right() <= viewport_rect.width() &&
             query_content_rect.bottom() + 96 <= viewport_rect.height();
-        CHECK_EQ(expect_empty, unoccluded.IsEmpty())
+        ASSERT_EQ(expect_empty, unoccluded.IsEmpty())
             << query_content_rect.ToString();
       }
     }
 
     timer_.NextLap();
   } while (!timer_.HasTimeLimitExpired());
 
   ++begin;
   LayerIteratorPosition next = begin;
   EXPECT_EQ(active_tree()->root_layer(), next.current_layer);
@@ skipping 40 matching lines @@
   // The opaque_layers add occlusion.
   for (int i = 0; i < kNumOpaqueLayers - 1; ++i) {
     LayerIteratorPosition pos = begin;
     tracker.EnterLayer(pos);
     tracker.LeaveLayer(pos);
     ++begin;
   }
   LayerIteratorPosition pos = begin;
   tracker.EnterLayer(pos);
   tracker.LeaveLayer(pos);
-
+/* This block doesn't seem to do anything, missing part of the loop body?

[Peter Kasting, 2016/06/10 05:50:06]

Dana, I think you wrote this, want to comment on what needs to be done here?

   gfx::Transform transform_to_target;
   transform_to_target.Translate(0, 96);
 
   do {
     Occlusion occlusion =
         tracker.GetCurrentOcclusionForLayer(transform_to_target);
     for (int x = 0; x < viewport_rect.width(); x += 256) {
       for (int y = 0; y < viewport_rect.height(); y += 256) {
         gfx::Rect query_content_rect(x, y, 256, 256);
         gfx::Rect unoccluded =
             occlusion.GetUnoccludedContentRect(query_content_rect);
+            occlusion.GetUnoccludedContentRect(query_content_rect);

[Peter Kasting, 2016/06/10 05:50:06]

Oops, ignore this typo line

       }
     }
 
     timer_.NextLap();
   } while (!timer_.HasTimeLimitExpired());
-
+*/
   ++begin;
   LayerIteratorPosition next = begin;
   EXPECT_EQ(active_tree()->root_layer(), next.current_layer);
 
   ++begin;
   EXPECT_EQ(end, begin);
 
   PrintResults();
 }
 
 }  // namespace
 }  // namespace cc