third_party/WebKit/Source/core/layout/line/InlineBox.cpp - Issue 2051333005: Let FrameView track object paint invalidations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineBox.cpp

Issue 2051333005: Let FrameView track object paint invalidations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TrackInvalidation

Patch Set: - Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutObject.h ('K') | « third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp ('k') | third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/InlineBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/InlineBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineBox.cpp

index f9e3fe6dfa4c58cc558effc1447331e1136dc11d..cd6c598d2ac489ed7c7d3ea36fe9c134ec283cae 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/InlineBox.cpp

@@ -66,7 +66,7 @@ void InlineBox::destroy()

// We do not need to issue invalidations if the page is being destroyed

// since these objects will never be repainted.

if (!m_lineLayoutItem.documentBeingDestroyed())

- m_lineLayoutItem.invalidateDisplayItemClient(*this);

+ m_lineLayoutItem.invalidateDisplayItemClient(*this, PaintInvalidationFull);

delete this;

}

@@ -384,7 +384,7 @@ LayoutPoint InlineBox::flipForWritingMode(const LayoutPoint& point) const

void InlineBox::invalidateDisplayItemClientsRecursively()

{

- getLineLayoutItem().invalidateDisplayItemClient(*this);

+ getLineLayoutItem().invalidateDisplayItemClient(*this, PaintInvalidationFull);

if (!isInlineFlowBox())

return;

for (InlineBox* child = toInlineFlowBox(this)->firstChild(); child; child = child->nextOnLine())