Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2051333005: Let FrameView track object paint invalidations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TrackInvalidation
Patch Set: - Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index 467b20cc519eef9a22e0f2f2a6b0bbe397d0257f..252d84e8ed729c0bf15645afe62f79b80492eab5 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -63,6 +63,7 @@ class Cursor;
class Element;
class FloatSize;
class HTMLFrameOwnerElement;
+class JSONArray;
class LayoutPart;
class LocalFrame;
class KURL;
@@ -322,7 +323,10 @@ public:
static void setInitialTracksPaintInvalidationsForTesting(bool);
void setTracksPaintInvalidations(bool);
- bool isTrackingPaintInvalidations() const { return m_isTrackingPaintInvalidations; }
+ bool isTrackingPaintInvalidations() const { return m_trackedObjectPaintInvalidations.get(); }
chrishtr 2016/06/17 07:06:49 Add a note that these methods are for testing only
Xianzhu 2016/06/17 18:39:31 Done.
+
+ void trackObjectPaintInvalidation(const DisplayItemClient&, PaintInvalidationReason);
+ PassRefPtr<JSONArray> trackedObjectPaintInvalidationsAsJSON() const;
using ScrollableAreaSet = HeapHashSet<Member<ScrollableArea>>;
void addScrollableArea(ScrollableArea*);
@@ -819,8 +823,6 @@ private:
bool m_safeToPropagateScrollToParent;
- bool m_isTrackingPaintInvalidations; // Used for testing.
-
unsigned m_visuallyNonEmptyCharacterCount;
unsigned m_visuallyNonEmptyPixelCount;
bool m_isVisuallyNonEmpty;
@@ -917,6 +919,12 @@ private:
bool m_needsScrollbarsUpdate;
bool m_suppressAdjustViewSize;
+
+ struct ObjectPaintInvalidation {
+ String name;
+ PaintInvalidationReason reason;
+ };
+ OwnPtr<Vector<ObjectPaintInvalidation>> m_trackedObjectPaintInvalidations;
};
inline void FrameView::incrementVisuallyNonEmptyCharacterCount(unsigned count)
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698