device/bluetooth/test/mock_bluetooth_gatt_notify_session.h - Issue 2051333004: Implement BluetoothGattNotifySession::Stop on Android, 2nd attempt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/test/mock_bluetooth_gatt_notify_session.h

Issue 2051333004: Implement BluetoothGattNotifySession::Stop on Android, 2nd attempt (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address new review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/test/mock_bluetooth_gatt_characteristic.h ('k') | device/bluetooth/test/mock_bluetooth_gatt_notify_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/test/mock_bluetooth_gatt_notify_session.h

diff --git a/device/bluetooth/test/mock_bluetooth_gatt_notify_session.h b/device/bluetooth/test/mock_bluetooth_gatt_notify_session.h

index 9d70333aa2f3ebe136c98b28bbbbc96215481668..a00ceccd6b36b6a0824fe728583de38f951de800 100644

--- a/device/bluetooth/test/mock_bluetooth_gatt_notify_session.h

+++ b/device/bluetooth/test/mock_bluetooth_gatt_notify_session.h

@@ -23,10 +23,9 @@ class MockBluetoothGattCharacteristic;

class MockBluetoothGattNotifySession : public BluetoothGattNotifySession {

public:

explicit MockBluetoothGattNotifySession(

- const std::string& characteristic_identifier);

+ base::WeakPtr<BluetoothRemoteGattCharacteristic> characteristic);

virtual ~MockBluetoothGattNotifySession();

- MOCK_CONST_METHOD0(GetCharacteristicIdentifier, std::string());

MOCK_METHOD0(IsActive, bool());

MOCK_METHOD1(Stop, void(const base::Closure&));