Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5019)

Unified Diff: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

Issue 2051333004: Implement BluetoothGattNotifySession::Stop on Android, 2nd attempt (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address new review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/proximity_auth/ble/bluetooth_low_energy_connection_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
diff --git a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
index 1d7df8a1c4620660b9a96a223c81d693b605dbab..eadea514f0743bb1c31ad567967f774a19e57b7f 100644
--- a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
+++ b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
@@ -652,10 +652,10 @@ IN_PROC_BROWSER_TEST_F(BluetoothLowEnergyApiTest, CharacteristicValueChanged) {
BluetoothGattNotifySession* session0 =
new testing::NiceMock<MockBluetoothGattNotifySession>(
- kTestCharacteristicId0);
+ chrc0_->GetWeakPtr());
BluetoothGattNotifySession* session1 =
new testing::NiceMock<MockBluetoothGattNotifySession>(
- kTestCharacteristicId2);
+ chrc2_->GetWeakPtr());
EXPECT_CALL(*chrc0_, StartNotifySession(_, _))
.Times(1)
@@ -1282,10 +1282,10 @@ IN_PROC_BROWSER_TEST_F(BluetoothLowEnergyApiTest, StartStopNotifications) {
BluetoothGattNotifySession* session0 =
new testing::NiceMock<MockBluetoothGattNotifySession>(
- kTestCharacteristicId0);
+ chrc0_->GetWeakPtr());
MockBluetoothGattNotifySession* session1 =
new testing::NiceMock<MockBluetoothGattNotifySession>(
- kTestCharacteristicId1);
+ chrc1_->GetWeakPtr());
EXPECT_CALL(*session1, Stop(_))
.Times(1)
« no previous file with comments | « no previous file | components/proximity_auth/ble/bluetooth_low_energy_connection_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698