chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc - Issue 2051333004: Implement BluetoothGattNotifySession::Stop on Android, 2nd attempt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

Issue 2051333004: Implement BluetoothGattNotifySession::Stop on Android, 2nd attempt (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase onto latest master Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/proximity_auth/ble/bluetooth_low_energy_connection_unittest.cc » ('j') | device/bluetooth/bluetooth_gatt_notify_session.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

diff --git a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

index 1d7df8a1c4620660b9a96a223c81d693b605dbab..eadea514f0743bb1c31ad567967f774a19e57b7f 100644

--- a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

+++ b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

@@ -652,10 +652,10 @@ IN_PROC_BROWSER_TEST_F(BluetoothLowEnergyApiTest, CharacteristicValueChanged) {

BluetoothGattNotifySession* session0 =

new testing::NiceMock<MockBluetoothGattNotifySession>(

- kTestCharacteristicId0);

+ chrc0_->GetWeakPtr());

BluetoothGattNotifySession* session1 =

new testing::NiceMock<MockBluetoothGattNotifySession>(

- kTestCharacteristicId2);

+ chrc2_->GetWeakPtr());

EXPECT_CALL(*chrc0_, StartNotifySession(_, _))

.Times(1)

@@ -1282,10 +1282,10 @@ IN_PROC_BROWSER_TEST_F(BluetoothLowEnergyApiTest, StartStopNotifications) {

BluetoothGattNotifySession* session0 =

new testing::NiceMock<MockBluetoothGattNotifySession>(

- kTestCharacteristicId0);

+ chrc0_->GetWeakPtr());

MockBluetoothGattNotifySession* session1 =

new testing::NiceMock<MockBluetoothGattNotifySession>(

- kTestCharacteristicId1);

+ chrc1_->GetWeakPtr());

EXPECT_CALL(*session1, Stop(_))

.Times(1)