Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2051313002: Encapsulate the CSSPrimitiveValue UnitType trie bethind a method that takes a StringView. (Closed)

Created:
4 years, 6 months ago by esprehn
Modified:
4 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Encapsulate the CSSPrimitiveValue UnitType trie bethind a method that takes a StringView. This removes the need for callers to manually branch on is8Bit() and also avoids having these separate functions in a header that's harder to discover. Now CSSPrimitiveValue has both unitTypeToString and stringToUnitType. BUG=615174 Committed: https://crrev.com/b2174605d75d559c7b1f3e4f87b150bbd399cdba Cr-Commit-Position: refs/heads/master@{#399090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -39 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/CSSPrimitiveValueUnitTrie.cpp.tmpl View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.h View 3 chunks +12 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/css/CSSPrimitiveValueUnitTrie.h View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSAngleValue.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051313002/1
4 years, 6 months ago (2016-06-09 22:56:45 UTC) #3
esprehn
4 years, 6 months ago (2016-06-09 23:50:37 UTC) #5
meade_UTC10
lgtm
4 years, 6 months ago (2016-06-10 00:01:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051313002/1
4 years, 6 months ago (2016-06-10 00:02:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_gn_rel on ...
4 years, 6 months ago (2016-06-10 00:58:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051313002/1
4 years, 6 months ago (2016-06-10 02:23:43 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 04:30:50 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 04:31:06 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 04:33:34 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2174605d75d559c7b1f3e4f87b150bbd399cdba
Cr-Commit-Position: refs/heads/master@{#399090}

Powered by Google App Engine
This is Rietveld 408576698