third_party/WebKit/LayoutTests/media/autoplay-muted.html - Issue 2051253002: Start autoplay muted videos with autoplay attribute when they are visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/autoplay-muted.html

Issue 2051253002: Start autoplay muted videos with autoplay attribute when they are visible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/autoplay-when-visible.html » ('j') | third_party/WebKit/LayoutTests/media/autoplay-when-visible.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/autoplay-muted.html

diff --git a/third_party/WebKit/LayoutTests/media/autoplay-muted.html b/third_party/WebKit/LayoutTests/media/autoplay-muted.html

index 2de88e10382cf8471b7711599dbd5f349cf0e3bf..5354465f752bf570403ac6438f5d91d9b2c68d67 100644

--- a/third_party/WebKit/LayoutTests/media/autoplay-muted.html

+++ b/third_party/WebKit/LayoutTests/media/autoplay-muted.html

@@ -1,5 +1,9 @@

<!DOCTYPE html>

+<html>

+<head>

esprehn 2016/06/21 21:28:41 you don't need <head> or <html>, just add <body>.

mlamouri (slow - plz ping) 2016/06/21 21:32:11 I could but having <title> outside of <head> isn't

esprehn 2016/06/21 21:36:39 The <title> won't be outside the head, just like i

<title>Test for autoplay of muted video</title>

+</head>

+<body>

@@ -35,6 +39,7 @@

async_test(function(t) {

var e = createMutedVideoElement();

e.autoplay = true;

+ document.body.appendChild(e);

var expectedEvents = [ 'canplay', 'play', 'playing'];

var eventWatcher = new EventWatcher(t, e, expectedEvents);

@@ -100,3 +105,5 @@

createMutedVideoElement().play());

}, "Test that muted videos don't autoplay when the setting is disabled");

</script>

+</body>

+</html>

esprehn 2016/06/21 21:28:41 remove