Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2051243002: Drop ResourceLoader (Closed)

Created:
4 years, 6 months ago by Nate Chapin
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, caseq+blink_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, sergeyv+blink_chromium.org, Nate Chapin, loading-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@startLoad
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop ResourceLoader BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 #

Patch Set 6 : Simplify didFinishLoading #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Patch Set 9 : fix test #

Patch Set 10 : Drop some unnecessary changes #

Patch Set 11 : Rebase #

Patch Set 12 : Rebase #

Patch Set 13 : Rebase #

Patch Set 14 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -460 lines) Patch
M third_party/WebKit/Source/core/fetch/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 2 3 4 5 6 7 7 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 2 3 4 5 6 7 8 9 10 10 chunks +14 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +41 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 16 chunks +184 lines, -57 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +6 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ResourceLoader.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 1 2 3 4 5 6 7 1 chunk +0 lines, -229 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceTest.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock.h View 1 2 3 4 5 6 7 4 chunks +13 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc View 1 2 3 4 5 6 7 3 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (29 generated)
Nate Chapin
The CQ bit was checked by japhet@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-08-29 22:55:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2051243002/140001
4 years, 3 months ago (2016-08-29 23:13:23 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-08-30 03:17:00 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/132487)
4 years, 3 months ago (2016-08-30 03:17:00 UTC) #4
Nate Chapin
The CQ bit was checked by japhet@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-08-30 19:45:11 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2051243002/160001
4 years, 3 months ago (2016-08-30 19:46:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-08-30 21:29:35 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/133197)
4 years, 3 months ago (2016-08-30 21:29:36 UTC) #8
Nate Chapin
The CQ bit was checked by japhet@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-08-30 21:46:09 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2051243002/180001
4 years, 3 months ago (2016-08-30 21:46:51 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-08-30 23:26:26 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/133267)
4 years, 3 months ago (2016-08-30 23:26:27 UTC) #12
Nate Chapin
The CQ bit was checked by japhet@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-06 16:12:11 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2051243002/200001
4 years, 3 months ago (2016-09-06 16:12:36 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-06 16:15:21 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/195355) chromium_presubmit on ...
4 years, 3 months ago (2016-09-06 16:15:22 UTC) #16
Nate Chapin
The CQ bit was checked by japhet@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-06 20:14:03 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2051243002/220001
4 years, 3 months ago (2016-09-06 20:15:02 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-06 20:24:43 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/124257) android_clang_dbg_recipe on ...
4 years, 3 months ago (2016-09-06 20:24:44 UTC) #20
Nate Chapin
The CQ bit was checked by japhet@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-06 20:56:43 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2051243002/240001
4 years, 3 months ago (2016-09-06 20:57:25 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-06 23:09:54 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/136852)
4 years, 3 months ago (2016-09-06 23:09:55 UTC) #24
Nate Chapin
The CQ bit was checked by japhet@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-12 23:23:51 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2051243002/260001
4 years, 3 months ago (2016-09-12 23:24:20 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-13 00:48:53 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/29371)
4 years, 3 months ago (2016-09-13 00:48:54 UTC) #28
Nate Chapin
3 years, 6 months ago (2017-06-15 23:25:08 UTC) #29 
Description was changed from

==========
Drop ResourceLoader

BUG=
==========

to

==========
Drop ResourceLoader

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698