Convert track-webvtt-tc[024-026] tests to testharness.js

third_party/WebKit/LayoutTests/media/track/track-helpers.js

Index: third_party/WebKit/LayoutTests/media/track/track-helpers.js
diff --git a/third_party/WebKit/LayoutTests/media/track/track-helpers.js b/third_party/WebKit/LayoutTests/media/track/track-helpers.js
index a377ae0628c054457dfd5bb0b4ea884d6ced089a..cd091ae788a20eb553fd91315bdd88587213cc2c 100644
--- a/third_party/WebKit/LayoutTests/media/track/track-helpers.js
+++ b/third_party/WebKit/LayoutTests/media/track/track-helpers.js
@@ -45,6 +45,18 @@ function assert_cue_fragment(cue, children) {
     assert_true(fragment.isEqualNode(cue.getCueAsHTML()));
 }
 
+function assert_cue_fragment_text(cue, children) {

[fs, 2016/06/10 12:52:18]

Maybe '...as_text' or '...as_textcontent'?

[Srirama, 2016/06/10 15:19:09]

Done.

+    var fragment = createFragment(children);
+    assert_equals(cue.getCueAsHTML().textContent, fragment.textContent);
+}
+
+function assert_cue_fragment_with_style(cue, children, style) {

[Srirama, 2016/06/10 11:53:51]

Should we merge this with "assert_cue_fragment" with a null check for style or
separate function is fine?

[fs, 2016/06/10 12:52:18]

Merging sounds like a good idea. Maybe even make it so that style can more
easily be applied "per node" (ought to be possible to just move the for-of loop
to cloneChildrenToFragment and specify in the same dictionary as 'type' and
'value'.)

[Srirama, 2016/06/10 13:57:04]

"Maybe even make it so that style can more" is some word missing after *make
it*?

[fs, 2016/06/10 14:04:38]

No =). 'it' refers to the (helper) function. Does s/make/change/ make it any
more clear for you?

[Srirama, 2016/06/10 15:19:09]

Understood :)

+    var fragment = createFragment(children);
+    for (var attr of Object.getOwnPropertyNames(style))
+        fragment.querySelector("span")[attr] = style[attr];
+    assert_true(fragment.isEqualNode(cue.getCueAsHTML()));
+}
+
 function createFragment(children) {
     var fragment = document.createDocumentFragment();
     cloneChildrenToFragment(fragment, children);