Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2051233003: Add use counter for parsing of filter functions with no arguments (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counter for parsing of filter functions with no arguments Count before deciding the future for this, and related, "features". BUG=618960 Committed: https://crrev.com/69dc0dd043ecad3018541eaae6239022a808aa99 Cr-Commit-Position: refs/heads/master@{#399378}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/css3/filters/usecounter-filter-function-no-arguments.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 5 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
fs
4 years, 6 months ago (2016-06-10 12:40:59 UTC) #2
Timothy Loh
On 2016/06/10 12:40:59, fs wrote: lgtm
4 years, 6 months ago (2016-06-10 12:50:25 UTC) #3
Ilya Sherman
histograms.xml lgtm
4 years, 6 months ago (2016-06-10 21:16:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051233003/1
4 years, 6 months ago (2016-06-11 14:41:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/188811) ios-device on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-11 14:42:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051233003/20001
4 years, 6 months ago (2016-06-11 16:50:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/237660)
4 years, 6 months ago (2016-06-11 18:56:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051233003/20001
4 years, 6 months ago (2016-06-11 19:02:02 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-11 20:33:47 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-11 20:33:51 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 20:35:32 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69dc0dd043ecad3018541eaae6239022a808aa99
Cr-Commit-Position: refs/heads/master@{#399378}

Powered by Google App Engine
This is Rietveld 408576698