Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2051233002: Remove more casts, part 7. (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove more casts, part 7. Replacing a void* member in CFX_SAXItem saves lots of casts. Committed: https://pdfium.googlesource.com/pdfium/+/77b909e059283c1d4c1654a626fc05c584af11a3

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -72 lines) Patch
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M fpdfsdk/fsdk_annothandler.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M xfa/fde/xml/cfx_saxreader.h View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_checksum.cpp View 2 chunks +44 lines, -42 lines 0 comments Download
M xfa/fxfa/include/xfa_checksum.h View 1 chunk +9 lines, -9 lines 1 comment Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 5 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan.
4 years, 6 months ago (2016-06-09 20:57:42 UTC) #2
dsinclair
lgtm https://codereview.chromium.org/2051233002/diff/1/xfa/fxfa/include/xfa_checksum.h File xfa/fxfa/include/xfa_checksum.h (right): https://codereview.chromium.org/2051233002/diff/1/xfa/fxfa/include/xfa_checksum.h#newcode30 xfa/fxfa/include/xfa_checksum.h:30: CXFA_SAXContext* OnTagEnter(const CFX_ByteStringC& bsTagName, Yaaa, so much nicer.
4 years, 6 months ago (2016-06-09 21:07:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051233002/1
4 years, 6 months ago (2016-06-09 21:07:56 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 21:08:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/77b909e059283c1d4c1654a626fc05c584af...

Powered by Google App Engine
This is Rietveld 408576698