Make initializing formals visible in the initializer list

Implement the language change that makes initializing formal parameters visible in the initializer list, but not in the constructor's body.

The feature is enabled with the flag --initializing-formal-access.

BUG=26655, 26656
R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/643fdb9dc8371adfd04ca8ab2acee87b53c8f2d3

[hausner, 2016-08-04 16:56:03]

Description was changed from

==========
Experimental change for initializing formals

For an initializing formal parameter this.x, introduces the implicitly final
parameter x in the initializer list and body of the constructor.

There is code in the io library (at least) that breaks with this change:

class _FileStream ... {
 ...
  _FileStream(this._path, this._position, this._end) {
    if (_position == null) _position = 0;  // <<<< runtime error.
  }
  ...


BUG=26655, 26656
==========

to

==========
Implement the language change that makes initializing formal parameters visible
in the initializer list, but not in the constructor's body.

The feature is enabled with the flag --initializing-formal-access.

BUG=26655, 26656
==========

[hausner, 2016-08-04 16:56:03]

hausner@google.com changed reviewers:
+ regis@google.com

[hausner, 2016-08-04 16:59:10]

Patchset #1 (id:1) has been deleted

[regis, 2016-08-04 17:13:50]

LGTM

Are there no tests yet?

[hausner, 2016-08-04 17:20:46]

Thank you. There are tests:

tests/language/initializing_formal_access_test.dart
tests/language/initializing_formal_capture_test.dart
tests/language/initializing_formal_final_test.dart
tests/language/initializing_formal_promotion_test.dart
tests/language/initializing_formal_scope_test.dart
tests/language/initializing_formal_type_test.dart

They enable the feature with the --initializing_formal_access flag.

[regis, 2016-08-04 17:25:10]

On 2016/08/04 17:20:46, hausner wrote:
> Thank you. There are tests:
> 
> tests/language/initializing_formal_access_test.dart
> tests/language/initializing_formal_capture_test.dart
> tests/language/initializing_formal_final_test.dart
> tests/language/initializing_formal_promotion_test.dart
> tests/language/initializing_formal_scope_test.dart
> tests/language/initializing_formal_type_test.dart
> 
> They enable the feature with the --initializing_formal_access flag.

Cool. So shouldn't an updated language.status file be part of this cl?
Thanks.

[hausner, 2016-08-04 17:33:00]

Oh, yes. Now that you mention it... Some tests still fail. Working on a fix,
will send another review. Thanks for catching this!

[hausner, 2016-08-04 17:59:34]

PTAL

[regis, 2016-08-04 18:03:58]

LGTM

[hausner, 2016-08-04 18:24:29]

Description was changed from

==========
Implement the language change that makes initializing formal parameters visible
in the initializer list, but not in the constructor's body.

The feature is enabled with the flag --initializing-formal-access.

BUG=26655, 26656
==========

to

==========
Implement the language change that makes initializing formal parameters visible
in the initializer list, but not in the constructor's body.

The feature is enabled with the flag --initializing-formal-access.

BUG=26655, 26656
R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/643fdb9dc8371adfd04ca8ab2acee87b53c8f2d3
==========

[hausner, 2016-08-04 18:24:30]

Committed patchset #2 (id:40001) manually as
643fdb9dc8371adfd04ca8ab2acee87b53c8f2d3 (presubmit successful).