Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2051193002: Revert of Disable tail calls inside Simple GM functions. (Closed)

Created:
4 years, 6 months ago by mtklein
Modified:
4 years, 6 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Disable tail calls inside Simple GM functions. (patchset #1 id:1 of https://codereview.chromium.org/2050473006/ ) Reason for revert: Appears to have broken Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug Original issue's description: > Disable tail calls inside Simple GM functions. > > I haven't found any way to turn off the particular optimization (-foptimize-sibling-calls) > per-function, but I can control optimization settings coarsely: > > - on GCC, we can pick a particular -O level, so I've picked -O1 which does not > enable -foptimize-sibling-calls > - on Clang, we can only disable all optimization for a function > - have no idea about MSVC > > This should make sure the simple GM functions, e.g. all_bitmap_configs_GM(), > show up on stack traces when we crash. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050473006 > > Committed: https://skia.googlesource.com/skia/+/eee3ced68f787aadc47fa274ca8e13b354ec920a TBR=reed@google.com,mtklein@chromium.org BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot Committed: https://skia.googlesource.com/skia/+/2843c42e594bf45f48a29f4195ec39aeeb92b2bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M gm/gm.h View 1 chunk +4 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mtklein
Created Revert of Disable tail calls inside Simple GM functions.
4 years, 6 months ago (2016-06-09 18:59:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051193002/1
4 years, 6 months ago (2016-06-09 19:00:43 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 19:20:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2843c42e594bf45f48a29f4195ec39aeeb92b2bc

Powered by Google App Engine
This is Rietveld 408576698