Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7802)

Unified Diff: chrome/browser/themes/browser_theme_pack_unittest.cc

Issue 2051123002: Make COLOR_CONTROL_BACKGROUND customizable from a theme extension (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/themes/browser_theme_pack_unittest.cc
diff --git a/chrome/browser/themes/browser_theme_pack_unittest.cc b/chrome/browser/themes/browser_theme_pack_unittest.cc
index c79c6c2031c1cfcb86b6a8d2b67b8b1a96e4d3e4..7d0880facbb46346aae3239e95fb03dd7f5ec26e 100644
--- a/chrome/browser/themes/browser_theme_pack_unittest.cc
+++ b/chrome/browser/themes/browser_theme_pack_unittest.cc
@@ -213,6 +213,10 @@ class BrowserThemePackTest : public ::testing::Test {
&color));
EXPECT_EQ(SK_ColorBLACK, color);
+ EXPECT_TRUE(
+ pack->GetColor(ThemeProperties::COLOR_CONTROL_BACKGROUND, &color));
+ EXPECT_EQ(SkColorSetRGB(10, 234, 123), color);
+
EXPECT_TRUE(pack->GetColor(ThemeProperties::COLOR_NTP_BACKGROUND,
&color));
EXPECT_EQ(SkColorSetRGB(57, 137, 194), color);
@@ -247,9 +251,6 @@ class BrowserThemePackTest : public ::testing::Test {
EXPECT_FALSE(pack->HasCustomImage(IDR_THEME_TAB_BACKGROUND_INCOGNITO));
#endif
- // Make sure we don't have phantom data.
Peter Kasting 2016/06/10 01:12:24 Why did this comment disappear?
Julien Isorce Samsung 2016/06/10 09:51:37 Oups, I'll add it back. Thx
- EXPECT_FALSE(pack->GetColor(ThemeProperties::COLOR_CONTROL_BACKGROUND,
- &color));
EXPECT_FALSE(pack->GetTint(ThemeProperties::TINT_FRAME, &actual));
}

Powered by Google App Engine
This is Rietveld 408576698