Create subdirectory and boilerplate for reviewbot app.

Create subdirectory and boilerplate for reviewbot app.

R=agable@chromium.org, cmp@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215574

[Mattias Nissler (ping if slow), 2013-07-25 21:43:22]

Please review. See the mail thread on chrome-infra I cc'ed you on for context.

[Mattias Nissler (ping if slow), 2013-07-29 18:33:34]

Gentle ping.

[agable, 2013-07-30 16:57:21]

LGTM % license

Please also request that chromium.googlesource.com/chromium/tools/reviewbot.git
be created as a mirror of this svn directory.

https://codereview.chromium.org/20511002/diff/1/reviewbot/LICENSE
File reviewbot/LICENSE (right):

https://codereview.chromium.org/20511002/diff/1/reviewbot/LICENSE#newcode1
reviewbot/LICENSE:1: // Copyright (c) 2013 The Chromium Authors. All rights
reserved.
a) Is this file necessary? Our other appengine apps (see chromium-build and
chromium-shortener, at least) just include the standard chromium license at the
top of each file, and not separately in the directory.
b) If it is necessary, please remove the C-style comments.

[Mattias Nissler (ping if slow), 2013-07-31 14:25:25]

Chase, Mark, can you help us figure out whether the LICENSE file is need or not?
For background, this CL establishes a repository location for a new appengine
app, alongside the other appengine apps we already have.

https://codereview.chromium.org/20511002/diff/1/reviewbot/LICENSE
File reviewbot/LICENSE (right):

https://codereview.chromium.org/20511002/diff/1/reviewbot/LICENSE#newcode1
reviewbot/LICENSE:1: // Copyright (c) 2013 The Chromium Authors. All rights
reserved.
On 2013/07/30 16:57:21, Aaron Gable wrote:
> a) Is this file necessary? Our other appengine apps (see chromium-build and
> chromium-shortener, at least) just include the standard chromium license at
the
> top of each file, and not separately in the directory.
> b) If it is necessary, please remove the C-style comments.

I have now idea whether this is necessary. I used chromium-status as inspiration
for this CL, and that project has the file. The file is also present in the main
Chrome source tree. I'll add cmp@ and mal@ in the hope they can shed some light.

[Mattias Nissler (ping if slow), 2013-08-02 09:54:17]

On 2013/07/31 14:25:25, Mattias Nissler wrote:
> Chase, Mark, can you help us figure out whether the LICENSE file is need or
not?

Turns out Mark is out till next week. In the mean time, I'll start sending
reviews for actual code.

> For background, this CL establishes a repository location for a new appengine
> app, alongside the other appengine apps we already have.
> 
> https://codereview.chromium.org/20511002/diff/1/reviewbot/LICENSE
> File reviewbot/LICENSE (right):
> 
> https://codereview.chromium.org/20511002/diff/1/reviewbot/LICENSE#newcode1
> reviewbot/LICENSE:1: // Copyright (c) 2013 The Chromium Authors. All rights
> reserved.
> On 2013/07/30 16:57:21, Aaron Gable wrote:
> > a) Is this file necessary? Our other appengine apps (see chromium-build and
> > chromium-shortener, at least) just include the standard chromium license at
> the
> > top of each file, and not separately in the directory.
> > b) If it is necessary, please remove the C-style comments.
> 
> I have now idea whether this is necessary. I used chromium-status as
inspiration
> for this CL, and that project has the file. The file is also present in the
main
> Chrome source tree. I'll add cmp@ and mal@ in the hope they can shed some
light.

[cmp, 2013-08-02 17:42:08]

I believe it is necessary, it may just be that in some of those projects we did
not add the LICENSE file.  So this LGTM on that issue.

We should go back and add a copy of the LICENSE file to the other directories at
some point.

[Mattias Nissler (ping if slow), 2013-08-05 07:37:59]

Thanks Chase, I'll keep the LICENSE file then.

https://codereview.chromium.org/20511002/diff/1/reviewbot/LICENSE
File reviewbot/LICENSE (right):

https://codereview.chromium.org/20511002/diff/1/reviewbot/LICENSE#newcode1
reviewbot/LICENSE:1: // Copyright (c) 2013 The Chromium Authors. All rights
reserved.
On 2013/07/31 14:25:25, Mattias Nissler wrote:
> On 2013/07/30 16:57:21, Aaron Gable wrote:
> > a) Is this file necessary? Our other appengine apps (see chromium-build and
> > chromium-shortener, at least) just include the standard chromium license at
> the
> > top of each file, and not separately in the directory.
> > b) If it is necessary, please remove the C-style comments.
> 
> I have now idea whether this is necessary. I used chromium-status as
inspiration
> for this CL, and that project has the file. The file is also present in the
main
> Chrome source tree. I'll add cmp@ and mal@ in the hope they can shed some
light.

Answering (b): All other copies of the file I've checked do have the comment
markers, so I'll keep them here as well for consistency.

[Mattias Nissler (ping if slow), 2013-08-05 08:36:44]

I committed, and gcl in its infinite wisdom committed the entire subdirectory
including all the un-reviewed changes, although they weren't part of the CL.
I'll remove these in a second...