Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: src/api.cc

Issue 2051043003: [snapshot] pass arguments as pointers, not references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@snapshotcreator
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/snapshot/code-serializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index d37e0c34dca964d5542301de0a8360f2e5180ab6..a8cf0309fcd8faf4c1d70dd4dbde4e48871dd016 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -469,14 +469,12 @@ StartupData SnapshotCreator::CreateBlob(
i::SnapshotByteSink context_sink;
i::PartialSerializer context_serializer(isolate, &startup_serializer,
&context_sink);
- // TODO(yangguo): support multiple contexts in the snapshot.
- DCHECK_EQ(1, contexts.length());
context_serializer.Serialize(&contexts[0]);
startup_serializer.SerializeWeakReferencesAndDeferred();
data->created_ = true;
- return i::Snapshot::CreateSnapshotBlob(startup_serializer,
- context_serializer);
+ return i::Snapshot::CreateSnapshotBlob(&startup_serializer,
+ &context_serializer);
}
StartupData V8::CreateSnapshotDataBlob(const char* embedded_source) {
« no previous file with comments | « no previous file | src/snapshot/code-serializer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698