Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: src/runtime/runtime-wasm.cc

Issue 2051043002: Implement Wasm GrowMemory opcode as a wasm runtime call (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ben's review, fix includes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime/runtime-wasm.cc
diff --git a/src/runtime/runtime-wasm.cc b/src/runtime/runtime-wasm.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d754ec8a822a014d500770a0ba5cf51f4d6411ad
--- /dev/null
+++ b/src/runtime/runtime-wasm.cc
@@ -0,0 +1,89 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/runtime/runtime-utils.h"
+
+#include "src/arguments.h"
+#include "src/assembler.h"
+#include "src/debug/debug.h"
+#include "src/factory.h"
+#include "src/objects-inl.h"
+#include "src/wasm/wasm-module.h"
+
+namespace v8 {
+namespace internal {
+
+RUNTIME_FUNCTION(Runtime_WasmGrowMemory) {
+ HandleScope scope(isolate);
+ DCHECK_EQ(2, args.length());
+ CONVERT_INT32_ARG_CHECKED(delta_pages, 0);
+ CONVERT_ARG_HANDLE_CHECKED(JSObject, module_object, 1);
+ RUNTIME_ASSERT(!module_object->IsNull());
+
+ byte* old_mem_start;
+ byte* new_mem_start;
+ uint32_t old_size, new_size;
+ const int kWasmMemArrayBuffer = 2;
+
+ // Get mem buffer and its size associated with the module js_object
+ Object* obj = module_object->GetInternalField(kWasmMemArrayBuffer);
+ Handle<JSArrayBuffer> old_buffer = Handle<JSArrayBuffer>::null();
+ old_buffer = Handle<JSArrayBuffer>(JSArrayBuffer::cast(obj));
+
+ if (old_buffer->byte_length()->Number() == 0) {
+ // If module object does not have linear memory associated with it,
+ // Allocate new array buffer of given size.
+ old_mem_start = reinterpret_cast<byte*>(old_buffer->backing_store());
+ old_size = 0;
+ // TODO(gdeepti): Figure out how to update new size correctly here.
+ new_size = delta_pages * wasm::WasmModule::kPageSize;
+ if (delta_pages > wasm::WasmModule::kMaxMemPages) {
+ THROW_NEW_ERROR_RETURN_FAILURE(
+ isolate, NewRangeError(MessageTemplate::kWasmTrapMemOutOfBounds));
+ }
+ new_mem_start =
+ reinterpret_cast<byte*>(isolate->array_buffer_allocator()->Allocate(
+ static_cast<int>(new_size)));
+ RUNTIME_ASSERT(new_mem_start != NULL);
+#if DEBUG
+ // Double check the API allocator actually zero-initialized the memory.
+ for (size_t i = old_size; i < new_size; i++) {
+ DCHECK_EQ(0, new_mem_start[i]);
+ }
+#endif
+ } else {
+ old_mem_start = reinterpret_cast<byte*>(old_buffer->backing_store());
+ old_size = old_buffer->byte_length()->Number();
+ new_size = old_size + delta_pages * wasm::WasmModule::kPageSize;
+ if (new_size >
+ wasm::WasmModule::kMaxMemPages * wasm::WasmModule::kPageSize) {
+ THROW_NEW_ERROR_RETURN_FAILURE(
+ isolate, NewRangeError(MessageTemplate::kWasmTrapMemOutOfBounds));
+ }
+ new_mem_start = reinterpret_cast<byte*>(realloc(old_mem_start, new_size));
+ RUNTIME_ASSERT(new_mem_start != NULL);
+ old_buffer->set_is_external(true);
+ isolate->heap()->UnregisterArrayBuffer(*old_buffer);
+ // Zero initializing uninitialized memory from realloc
+ for (size_t i = old_size; i < new_size; i++) {
+ new_mem_start[i] = 0;
+ }
+ }
+
+ Handle<JSArrayBuffer> buffer = isolate->factory()->NewJSArrayBuffer();
+ JSArrayBuffer::Setup(buffer, isolate, false, new_mem_start, new_size);
+ buffer->set_is_neuterable(false);
+
+ // Set new buffer to be wasm memory
+ module_object->SetInternalField(kWasmMemArrayBuffer, *buffer);
+
+ RUNTIME_ASSERT(wasm::UpdateWasmModuleMemory(
+ module_object, old_mem_start, new_mem_start, old_size, new_size));
+
+ return *isolate->factory()->NewNumberFromInt(old_size /
+ wasm::WasmModule::kPageSize);
+}
+
+} // namespace internal
+} // namespace v8
« src/compiler/wasm-compiler.cc ('K') | « src/runtime/runtime.h ('k') | src/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698