src/arm/assembler-arm.cc - Issue 2051043002: Implement Wasm GrowMemory opcode as a wasm runtime call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/assembler-arm.cc

Issue 2051043002: Implement Wasm GrowMemory opcode as a wasm runtime call (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Ben's review, fix includes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/assembler-arm.cc

diff --git a/src/arm/assembler-arm.cc b/src/arm/assembler-arm.cc

index a511db6f2cfcd850434544a62f5c39689750d96f..054444567d13e05b24d2e50be05f562d8cb8855e 100644

--- a/src/arm/assembler-arm.cc

+++ b/src/arm/assembler-arm.cc

@@ -256,7 +256,7 @@ void RelocInfo::update_wasm_memory_reference(

if (IsWasmMemoryReference(rmode_)) {

Address updated_memory_reference;

DCHECK(old_base <= wasm_memory_reference() &&

- wasm_memory_reference() < old_base + old_size);

+ wasm_memory_reference() <= old_base + old_size);

updated_memory_reference = new_base + (wasm_memory_reference() - old_base);

DCHECK(new_base <= updated_memory_reference &&

updated_memory_reference < new_base + new_size);