Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3013)

Unified Diff: chrome/common/extensions/api/networking_private/networking_private_crypto.cc

Issue 2050983002: Cast device revocation checking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: API change: use base::Time instead of base::Time::ExplodedTime Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cast_certificate.gypi » ('j') | components/cast_certificate/cast_cert_validator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/networking_private/networking_private_crypto.cc
diff --git a/chrome/common/extensions/api/networking_private/networking_private_crypto.cc b/chrome/common/extensions/api/networking_private/networking_private_crypto.cc
index 289899cdd110c4107fd0752734581ebb8b17556e..ea6c301180fc1f074e87d626246db8b72fe7d717 100644
--- a/chrome/common/extensions/api/networking_private/networking_private_crypto.cc
+++ b/chrome/common/extensions/api/networking_private/networking_private_crypto.cc
@@ -51,8 +51,7 @@ bool VerifyCredentials(
const std::string& signature,
const std::string& data,
const std::string& connected_mac) {
- base::Time::Exploded now;
- base::Time::Now().UTCExplode(&now);
+ base::Time now = base::Time::Now();
return VerifyCredentialsAtTime(certificate, intermediate_certificates,
signature, data, connected_mac, now);
}
@@ -63,7 +62,7 @@ bool VerifyCredentialsAtTime(
const std::string& signature,
const std::string& data,
const std::string& connected_mac,
- const base::Time::Exploded& time) {
+ const base::Time& time) {
static const char kErrorPrefix[] = "Device verification failed. ";
std::vector<std::string> headers;
@@ -97,7 +96,8 @@ bool VerifyCredentialsAtTime(
std::unique_ptr<cast_crypto::CertVerificationContext> verification_context;
if (!cast_crypto::VerifyDeviceCert(certs, time, &verification_context,
- &unused_policy)) {
+ &unused_policy, nullptr,
+ cast_crypto::CRLPolicy::CRL_OPTIONAL)) {
LOG(ERROR) << kErrorPrefix << "Failed verifying cast device cert";
return false;
}
« no previous file with comments | « no previous file | components/cast_certificate.gypi » ('j') | components/cast_certificate/cast_cert_validator.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698