Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: components/cast_certificate/cast_cert_validator_unittest.cc

Issue 2050983002: Cast device revocation checking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test suite runner. Updated some tests. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cast_certificate/cast_cert_validator_unittest.cc
diff --git a/components/cast_certificate/cast_cert_validator_unittest.cc b/components/cast_certificate/cast_cert_validator_unittest.cc
index e363a1d47c859bbf0f6b1646689cb7ff6fabc6f0..be7e63b1af98945ec2ab9a915870565c82eb5aae 100644
--- a/components/cast_certificate/cast_cert_validator_unittest.cc
+++ b/components/cast_certificate/cast_cert_validator_unittest.cc
@@ -46,7 +46,10 @@ void RunTest(TestResult expected_result,
std::unique_ptr<CertVerificationContext> context;
CastDeviceCertPolicy policy;
- bool result = VerifyDeviceCert(certs, time, &context, &policy);
+ CRLOptions crl_options;
+ crl_options.crl_required = false;
+ bool result =
+ VerifyDeviceCert(certs, time, &context, &policy, nullptr, crl_options);
if (expected_result == RESULT_FAIL) {
ASSERT_FALSE(result);
@@ -88,26 +91,17 @@ void RunTest(TestResult expected_result,
}
}
-// Creates a time in UTC at midnight.
-base::Time::Exploded CreateDate(int year, int month, int day) {
- base::Time::Exploded time = {0};
- time.year = year;
- time.month = month;
- time.day_of_month = day;
- return time;
-}
-
// Returns 2016-04-01 00:00:00 UTC.
//
// This is a time when most of the test certificate paths are
// valid.
base::Time::Exploded AprilFirst2016() {
- return CreateDate(2016, 4, 1);
+ return cast_certificate::testing::CreateDate(2016, 4, 1);
}
// Returns 2015-01-01 00:00:00 UTC.
base::Time::Exploded JanuaryFirst2015() {
- return CreateDate(2015, 1, 1);
+ return cast_certificate::testing::CreateDate(2015, 1, 1);
}
// Returns 2040-03-01 00:00:00 UTC.
@@ -115,7 +109,7 @@ base::Time::Exploded JanuaryFirst2015() {
// This is so far in the future that the test chains in this unit-test
// should all be invalid.
base::Time::Exploded MarchFirst2040() {
- return CreateDate(2040, 3, 1);
+ return cast_certificate::testing::CreateDate(2040, 3, 1);
}
// Tests verifying a valid certificate chain of length 2:

Powered by Google App Engine
This is Rietveld 408576698